This repository was archived by the owner on Jun 6, 2024. It is now read-only.
Conversation
This reverts commit f8b4022.
oleganza
reviewed
Dec 4, 2020
oleganza
reviewed
Dec 7, 2020
oleganza
reviewed
Dec 7, 2020
| height, | ||
| prev: prev.0, | ||
| timestamp_ms, | ||
| txroot: txroot.0, |
Contributor
There was a problem hiding this comment.
maybe use the Hash type that we already have?
Contributor
Author
There was a problem hiding this comment.
It is hard question about newtypes. API users should not be aware of what newtypes we use inside the application. But using them will make code a little easier because they are used internally by the application.
oleganza
reviewed
Dec 7, 2020
oleganza
reviewed
Dec 7, 2020
oleganza
reviewed
Dec 8, 2020
node/src/api/network.rs
Outdated
| .or(submit(bc)) | ||
| } | ||
|
|
||
| fn status(bc: BlockchainRef) -> impl Filter<Extract = impl warp::Reply, Error = warp::Rejection> + Clone { |
Contributor
There was a problem hiding this comment.
Would it be more readable if those routes were declared as local variables instead of functions? Then we wouldn't need those long return type definitions all over the place.
oleganza
reviewed
Dec 8, 2020
oleganza
reviewed
Dec 8, 2020
| ) -> ResponseResult<responses::NewReceiver> { | ||
| let mut wallet_ref = wallet.write().await; | ||
| let update_wallet = |wallet: &mut Wallet| { | ||
| let requests::NewReceiver { flv, qty, exp } = req; // TODO: expiration time? |
Contributor
There was a problem hiding this comment.
Hmm.. I'm starting to think that the expiration time is the storage policy of the node. How about we remove this parameter from the request entirely for now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server api implementation for
node.A part of #468.
Schema of api: https://github.com/stellar/slingshot/blob/main/node/api.md