Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates all example contracts to use soroban-sdk version 25.0.2, upgrading from versions 23.0.1 and 23.4.0. The update brings new dependencies and enhanced event testing capabilities as demonstrated in the events example.
Changes:
- Updated soroban-sdk from v23.x to v25.0.2 across all example contracts
- Updated related dependencies (soroban-token-sdk, soroban-poseidon, soroban-ledger-snapshot) to v25.x
- Enhanced event testing in the events example to demonstrate new SDK v25 features
- Updated test snapshots to reflect protocol version 25 and new ledger entry format
- Modified Makefile to exclude circuits directories from build process
Reviewed changes
Copilot reviewed 44 out of 84 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workspace/Cargo.toml | Updated workspace soroban-sdk dependency to 25.0.2 |
| workspace/Cargo.lock | Updated all soroban-* and stellar-* dependencies with new transitive dependencies |
| Various example Cargo.toml files | Consistently updated soroban-sdk to 25.0.2 in dependencies and dev-dependencies |
| Various example Cargo.lock files | Lockfile updates reflecting new dependency versions and additions (ark-bn254, hash32, heapless, etc.) |
| events/src/test.rs | Showcased new event testing patterns with #[contractevent] macro and filter_by_contract |
| mint-lock/test_snapshots/* | Updated protocol version to 25 and ledger entry format |
| eth_abi/test_snapshots/* | Updated protocol version to 25 and ledger entry format |
| Makefile | Added circuits directory exclusion and build logging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
approved these changes
Feb 4, 2026
Contributor
Author
|
@leighmcculloch removed your review as I also updated to |
leighmcculloch
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update examples to use soroban-sdk v25.
Also includes test updates for the
eventsexample to showcase new event testing options.