Closed
Conversation
9ab7f44 to
7788ad8
Compare
Contributor
|
For context: what was core doing when you gathered those performance numbers? On a lightly loaded system, even logging bubbles up as a non trivial CPU consumer. Also, what's the impact of the changes separately? |
Contributor
Author
|
Undesirable change, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses stellar/medida#13 so don't approve it until that one lands.
Adds a couple helper types for caching EasyLogging++ log-level lookups and batching Medida writes. Low-ish-hanging CPU overhead fruit. Measuring this with perf is quite noisy and these results may not be especially reproducible, but it does look to be a reasonable improvement to me:
Before:
After