Small fixes

.gitignore

@@ -91,6 +91,10 @@ compile_commands.json
 /scripts/*.graphml
 /scripts/*.json
 
+# tracy binaries
+/tracy-capture
+/tracy-gui
+
 # test output
 stellar-core-test-*
 test-partitions.*

docs/software/commands.md

@@ -420,20 +420,6 @@ Most commands return their results in JSON format.
   `sorobaninfo?format=detailed` command to compare against the existing settings to see exactly
   what is changing.
 
-* **surveytopology**
-  `surveytopology?duration=DURATION&node=NODE_ID`<br>
-  **This command is deprecated and will be removed in a future release. Use the
-  new time sliced survey interface instead (`startsurveycollecting`,
-  `stopsurveycollecting`, `surveytopologytimesliced`, and `getsurveyresults`).**
-  Starts a survey that will request peer connectivity information from nodes
-  in the backlog. `DURATION` is the number of seconds this survey will run
-  for, and `NODE_ID` is the public key you will add to the backlog to survey.
-  Running this command while the survey is running will add the node to the
-  backlog and reset the timer to run for `DURATION` seconds.  See [Changing
-  default survey behavior](#changing-default-survey-behavior) for details about
-  the default survey behavior, as well as how to change that behavior or opt-out
-  entirely.
-
 * **stopsurvey**
   `stopsurvey`<br>
   Will stop the survey if one is running. Noop if no survey is running

lib/util/basen.h

@@ -1,5 +1,3 @@
-#pragma once
-
 /**
  * base-n, 1.0
  * Copyright (C) 2012 Andrzej Zawadzki (azawadzki@gmail.com)

src/Makefile.am

@@ -435,7 +435,6 @@ else # !USE_POSTGRES
 TESTS=test/selftest-nopg
 endif # !USE_POSTGRES
 TESTS += test/check-nondet
-TESTS += test/check-sorobans
 
 format: always
 if USE_CLANG_FORMAT

src/test/check-nondet

@@ -39,3 +39,10 @@ then
     echo "to calls to std::uniform_int_distribution, which varies between compilers."
     exit 1
 fi
+
+if git grep 'SecretKey::random' '**/test/*.h' '**/test/*.cpp'
+then
+    echo
+    echo "please use SecretKey::pseudoRandomForTesting() instead of SecretKey::random() in tests"
+    exit 1
+fi

src/test/selftest-nopg

@@ -4,4 +4,5 @@
 # under the Apache License, Version 2.0. See the COPYING file at the root
 # of this distribution or at http://www.apache.org/licenses/LICENSE-2.0
 
-exec "${top_srcdir}/src/test/selftest-parallel" "${top_srcdir}/src/test/run-selftest-nopg"
+exec "${top_srcdir}/src/test/selftest-parallel" "${top_srcdir}/src/test/run-selftest-nopg" \
+    && exec "${top_srcdir}/src/test/check-sorobans"

src/test/selftest-pg

@@ -4,4 +4,5 @@
 # under the Apache License, Version 2.0. See the COPYING file at the root
 # of this distribution or at http://www.apache.org/licenses/LICENSE-2.0
 
-exec "${top_srcdir}/src/test/selftest-parallel" "${top_srcdir}/src/test/run-selftest-pg"
+"${top_srcdir}/src/test/selftest-parallel" "${top_srcdir}/src/test/run-selftest-pg" \
+    && exec "${top_srcdir}/src/test/check-sorobans"