Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/stellar-rpc/internal/methods/get_ledgers.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,17 @@ func (h ledgersHandler) getLedgers(
if err != nil {
return protocol.GetLedgersResponse{}, err
}
cursor := strconv.Itoa(int(ledgers[len(ledgers)-1].Sequence))

var cursor string
if len(ledgers) > 0 {
cursor = strconv.FormatUint(uint64(ledgers[len(ledgers)-1].Sequence), 10)
} else {
if request.Pagination != nil && request.Pagination.Cursor != "" {
cursor = request.Pagination.Cursor
} else { // start > 0 by validation
cursor = strconv.FormatUint(uint64(start-1), 10)
}
}

return protocol.GetLedgersResponse{
Ledgers: ledgers,
Expand Down
84 changes: 84 additions & 0 deletions cmd/stellar-rpc/internal/methods/get_ledgers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -445,3 +445,87 @@ func TestFetchLedgersErrors(t *testing.T) {
mockTx.AssertExpectations(t)
})
}

// TestGetLedgers_EmptyBatchGetLedgersResult is a regression test that ensures
// when GetLedgerRange reports data but BatchGetLedgers returns an empty slice,
// getLedgers returns an empty page with a stable cursor and does not panic.
func TestGetLedgers_EmptyBatchGetLedgersResult(t *testing.T) {
ctx := t.Context()

t.Run("empty result with cursor", func(t *testing.T) {
mockReader := new(MockLedgerReader)
mockReaderTx := new(MockLedgerReaderTx)

handler := ledgersHandler{
ledgerReader: mockReader,
maxLimit: 100,
defaultLimit: 5,
}

localRange := ledgerbucketwindow.LedgerRange{
FirstLedger: ledgerbucketwindow.LedgerInfo{Sequence: 100},
LastLedger: ledgerbucketwindow.LedgerInfo{Sequence: 200},
}

mockReader.On("NewTx", ctx).Return(mockReaderTx, nil)
mockReaderTx.On("Done").Return(nil)
mockReaderTx.On("GetLedgerRange", ctx).Return(localRange, nil)
// BatchGetLedgers returns empty slice even though GetLedgerRange indicates data exists
mockReaderTx.On("BatchGetLedgers", ctx, uint32(151), uint32(155)).
Return([]db.LedgerMetadataChunk{}, nil)

request := protocol.GetLedgersRequest{
Pagination: &protocol.LedgerPaginationOptions{
Cursor: "150",
Limit: 5,
},
}

response, err := handler.getLedgers(ctx, request)
require.NoError(t, err)
assert.Empty(t, response.Ledgers)
// Cursor should echo the request cursor for stability
assert.Equal(t, "150", response.Cursor)
assert.Equal(t, uint32(200), response.LatestLedger)

mockReader.AssertExpectations(t)
mockReaderTx.AssertExpectations(t)
})

t.Run("empty result without cursor", func(t *testing.T) {
mockReader := new(MockLedgerReader)
mockReaderTx := new(MockLedgerReaderTx)

handler := ledgersHandler{
ledgerReader: mockReader,
maxLimit: 100,
defaultLimit: 5,
}

localRange := ledgerbucketwindow.LedgerRange{
FirstLedger: ledgerbucketwindow.LedgerInfo{Sequence: 100},
LastLedger: ledgerbucketwindow.LedgerInfo{Sequence: 200},
}

mockReader.On("NewTx", ctx).Return(mockReaderTx, nil)
mockReaderTx.On("Done").Return(nil)
mockReaderTx.On("GetLedgerRange", ctx).Return(localRange, nil)
// BatchGetLedgers returns empty slice even though GetLedgerRange indicates data exists
mockReaderTx.On("BatchGetLedgers", ctx, uint32(100), uint32(104)).
Return([]db.LedgerMetadataChunk{}, nil)

request := protocol.GetLedgersRequest{
StartLedger: 100,
}

response, err := handler.getLedgers(ctx, request)
require.NoError(t, err)
assert.Empty(t, response.Ledgers)
// Cursor should be start-1 (99) when no cursor provided and no results
assert.Equal(t, "99", response.Cursor)
assert.Equal(t, uint32(200), response.LatestLedger)

mockReader.AssertExpectations(t)
mockReaderTx.AssertExpectations(t)
})
}
Loading