Return errors properly instead of just panicking#602
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request improves error handling in the CGo interface by replacing panic calls with proper error logging and returning empty structs to signal errors to the Rust caller. This is a defensive programming improvement that allows errors to be gracefully handled instead of crashing the program when the Core node returns invalid XDR data.
Changes:
- Replaced two panic calls with error logging and empty struct returns in
SnapshotSourceGetfunction - Added error logging for
SafeUnmarshal()andMarshalBinary()failures
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tamirms
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prefer errors to panics.
Why
While these branches should be impossible to hit under normal circumstances (e.g. a failed unmarshaling would indicate that the Core node is returning invalid XDR), it is still good defensive programming.
Known limitations
n/a