Store failed operations along with the specific result codes by aditya1702 · Pull Request #474 · stellar/wallet-backend

aditya1702 · 2026-01-30T16:41:07Z

What

Added ResultCode (string) and Successful (boolean) fields to the Operation type across all layers (database, GraphQL schema, data models, and client types)
Implemented comprehensive result code extraction logic for all Stellar operation types in codes.go with extensive test coverage
Updated database schema with new required fields and a partial index on failed operations
Modified participant processing to handle operations from both successful and failed transactions

Why

We were skipping failed operations and their state changes. However, freighter needs to show history for all failed txns/ops.
We were not storing result code and the specific inner result code for each operation

Known limitations

N/A

Issue that this PR addresses

Closes #475

Adds AccountChange struct and AccountOpType constants (CREATE/UPDATE/REMOVE) to track native XLM balance changes during ingestion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Processes xdr.LedgerEntryTypeAccount ledger changes to extract native XLM balance modifications. Skips signer-only changes using AccountChangedExceptSigners(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Adds accountChanges slice to IndexerBuffer with Push/Get methods. Updates Merge() and Clear() to handle account changes. Extends IndexerBufferInterface with account change methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replaces TrustLinesProcessorInterface with generic LedgerChangeProcessor[T] that works for both trustline and account processors. Processes both in same loop for efficiency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Adds NativeBalance struct and implements: - GetNativeBalance: query native balance for an account - BatchUpsertNativeBalances: upsert/delete for live ingestion - BulkInsertNativeBalances: COPY protocol for checkpoint population Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Updates ingest_live.go to get account changes directly from buffer (not filtered data) since native balances should be tracked for all accounts regardless of participant filtering. Updates ingest_backfill.go to include AccountChanges in BatchTokenChanges struct and aggregate them during catchup mode for proper ordering. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replaces RPC calls for native XLM balance with PostgreSQL queries: - BalancesByAccountAddress now fetches native balance from DB - BalancesByAccountAddresses fetches native balance in parallel Phase 1 - Adds buildNativeBalanceFromDB helper function - Updates accountKeyInfo struct to include nativeBalance field - Removes native XLM ledger key building (SAC contracts only now) This eliminates RPC round-trips for native balance queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…ance

…layer - Delete TrustlineWithBalance struct (redundant with Trustline) - Replace BatchAddContracts + BulkInsertContracts with BatchInsertContractTokens - Replace BulkInsertTrustlines with BatchInsertTrustlines using []Trustline signature - Update interface to reflect new consolidated methods Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Replace trustlineEntry with wbdata.Trustline in trustlineBatch - Update batch.add to include ledger parameter - Change batch.count field to batch.count() method - Update ProcessTokenChanges to use BatchInsertContractTokens - Update storeContractsInPostgres to use BatchInsertContractTokens - Simplify flushTrustlineBatch to use BatchInsertTrustlines directly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Rename TestAccountTokensModel_BulkInsertTrustlines to TestAccountTokensModel_BatchInsertTrustlines - Rename TestAccountTokensModel_BatchAddContracts to TestAccountTokensModel_BatchInsertContractTokens - Remove TestAccountTokensModel_BulkInsertContracts (merged into BatchInsertContractTokens tests) - Update all TrustlineWithBalance usages to Trustline struct - Update metrics mock expectations to new function names Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Update BulkInsertTrustlines to BatchInsertTrustlines with []Trustline - Update BulkInsertContracts to BatchInsertContractTokens Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- Create migration for account_sac_balances table to store SAC balances for contract addresses (C...) - Add SACBalanceChange type and SACBalanceOp enum to indexer types

- Follows TrustlinesProcessor pattern for processing ledger changes - Extracts absolute balance values from SAC contract data entries - Only processes contract addresses (C...) - G-addresses use trustlines - Extracts amount, authorized, and clawback fields from SAC balance map

- Add sacBalancesProcessor field to Indexer struct - Initialize processor in NewIndexer constructor - Call processor in processTransaction and push results to buffer - Add PushSACBalanceChange and GetSACBalanceChanges buffer methods - Update Merge and Clear to handle SAC balance changes

- Add SACBalance struct with balance, is_authorized, is_clawback_enabled fields - Add GetSACBalances for reading SAC balances from DB - Add BatchUpsertSACBalances for live ingestion upserts/deletes - Add BulkInsertSACBalances for checkpoint population via COPY

- Add sacBalanceChanges parameter to ProcessTokenChanges interface - Implement SAC balance processing with deduplication and sorting - Update all callers in ingest_live.go and ingest_backfill.go - Update BatchTokenChanges struct to include SACBalanceChanges - Update mock and all test files

- Add SACBalances field to checkpointData struct - Add sacBalanceEntry struct to hold extracted balance data - Extract SAC balance values during checkpoint scanning for C-addresses - Add extractSACBalanceFromValue helper to parse balance map - Add storeSACBalancesInPostgres to insert verified SAC balances - Use strkey.IsValidContract for proper address validation

- Add GetSACBalances to TokenCacheReader interface - Implement GetSACBalances in tokenCacheService - Add buildSACBalanceFromDB helper function - Add sacBalances field to accountKeyInfo struct - Fetch SAC balances from DB for contract addresses (C...) - Skip RPC calls for SAC contracts when address is contract - Update mock with GetSACBalances method

- Add result_code TEXT NOT NULL and successful BOOLEAN NOT NULL columns to migration - Add partial index on successful column for failed operations - Add ResultCode and Successful fields to Operation struct

- Create ForOperationResult function to extract result codes from XDR - Handle outer codes (op_bad_auth, op_no_source_account, etc.) - Handle inner codes via switch on all operation types - Based on Horizon's codes implementation

- Add opIndex and opResults parameters - Call ForOperationResult to get result code and success status - Set ResultCode and Successful fields on Operation

- Remove early return for failed transactions in GetOperationsParticipants - Skip Soroban participants for failed txs (they don't have ledger changes)

- Get operation results using tx.Result.OperationResults() - Pass opIndex and opResults to ConvertOperation

- Update BatchInsert to include result_code and successful columns - Update BatchCopy to include result_code and successful columns

- Add resultCode: String! field - Add successful: Boolean! field - Regenerate GraphQL code

- Add codes_test.go with unit tests for ForOperationResult - Update utils_test.go Test_ConvertOperation with new signature - Update all SQL INSERT statements in test files to include result_code and successful columns

…ExtendFootprintTTLResult

Copilot

Pull request overview

This pull request adds support for storing operation result codes and success status alongside operation data. The changes enable the system to track both successful and failed operations with their specific result codes, providing more granular information about operation outcomes.

Changes:

Added ResultCode (string) and Successful (boolean) fields to the Operation type across all layers (database, GraphQL schema, data models, and client types)
Implemented comprehensive result code extraction logic for all Stellar operation types in codes.go with extensive test coverage
Updated database schema with new required fields and a partial index on failed operations
Modified participant processing to handle operations from both successful and failed transactions

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
internal/db/migrations/2025-06-10.3-create_indexer_table_operations.sql	Added `result_code` and `successful` columns to operations table with partial index on failed operations
pkg/wbclient/types/types.go	Added `ResultCode` and `Successful` fields to Operation type for client API
internal/indexer/types/types.go	Added `ResultCode` and `Successful` fields to Operation type for indexer
internal/serve/graphql/schema/operation.graphqls	Exposed `resultCode` and `successful` fields in GraphQL schema
internal/indexer/processors/codes.go	New file implementing result code extraction for all operation types
internal/indexer/processors/codes_test.go	Comprehensive unit tests for result code extraction
internal/indexer/processors/utils.go	Updated `ConvertOperation` to extract and populate result codes
internal/indexer/processors/participants.go	Removed early return for failed transactions to process all operations
internal/data/operations.go	Updated batch insert and copy operations to include new fields
internal/integrationtests/data_validation_test.go	Added validation for operation result codes in integration tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/integrationtests/data_validation_test.go

internal/indexer/processors/codes.go

Copilot · 2026-01-30T17:45:34Z

internal/indexer/processors/codes.go

+	case xdr.ManageBuyOfferResultCodeManageBuyOfferSellNoIssuer:
+		return "op_sell_no_issuer", nil
+	case xdr.ManageBuyOfferResultCodeManageBuyOfferBuyNoIssuer:
+		return "buy_no_issuer", nil


Inconsistent naming convention: The result code "buy_no_issuer" is missing the "op_" prefix, unlike the similar code "op_sell_no_issuer" on line 226. For consistency with the naming convention used throughout this file, this should be "op_buy_no_issuer".

resolved this

internal/indexer/processors/codes.go

internal/db/migrations/2025-06-10.3-create_indexer_table_operations.sql

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

aditya1702 and others added 30 commits January 14, 2026 13:21

Add AccountChange type for native balance tracking

8dcdb6d

Adds AccountChange struct and AccountOpType constants (CREATE/UPDATE/REMOVE) to track native XLM balance changes during ingestion. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add AccountsProcessor for native balance tracking

9b2c5dc

Processes xdr.LedgerEntryTypeAccount ledger changes to extract native XLM balance modifications. Skips signer-only changes using AccountChangedExceptSigners(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add account changes to IndexerBuffer

cf4ca36

Adds accountChanges slice to IndexerBuffer with Push/Get methods. Updates Merge() and Clear() to handle account changes. Extends IndexerBufferInterface with account change methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add native balance to account tokens

2afe938

Update ingestion to process account changes

35c500e

fix make check

a7aee8b

remove redundant function to upsert trustlines

24c68ff

Merge branch 'calculate-balances-using-changes' into store-native-bal…

4715086

…ance

Update account_tokens.go

a4b66ef

test: update service layer tests for new batch function names

c0fdaf2

- Update BulkInsertTrustlines to BatchInsertTrustlines with []Trustline - Update BulkInsertContracts to BatchInsertContractTokens Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

remove unused code

bf88fcf

Fix failing tests

1de9854

Add account_sac_balances table and SACBalanceChange type

20e1e87

- Create migration for account_sac_balances table to store SAC balances for contract addresses (C...) - Add SACBalanceChange type and SACBalanceOp enum to indexer types

Store SAC balances while checkpointing

aa0297f

fix make check

90715c4

fix make check - 2

845e62b

Use SAC balances from DB

5d14675

aditya1702 added 16 commits January 30, 2026 09:44

Add isFeeBump column to transactions table

51201e1

Merge branch 'main' into result-xdr

ac9d6f8

Add result_code and successful columns to operations table

daabaed

- Add result_code TEXT NOT NULL and successful BOOLEAN NOT NULL columns to migration - Add partial index on successful column for failed operations - Add ResultCode and Successful fields to Operation struct

Update ConvertOperation to extract result codes

1b98c32

- Add opIndex and opResults parameters - Call ForOperationResult to get result code and success status - Set ResultCode and Successful fields on Operation

Process ALL operations regardless of transaction success

fc291e9

- Remove early return for failed transactions in GetOperationsParticipants - Skip Soroban participants for failed txs (they don't have ledger changes)

Pass operation results to ConvertOperation

54ff539

- Get operation results using tx.Result.OperationResults() - Pass opIndex and opResults to ConvertOperation

Update data layer for new operation columns

0b3c35e

- Update BatchInsert to include result_code and successful columns - Update BatchCopy to include result_code and successful columns

Update GraphQL schema with new Operation fields

a65c511

- Add resultCode: String! field - Add successful: Boolean! field - Regenerate GraphQL code

Update tests for new operation result_code and successful columns

7af5f84

- Add codes_test.go with unit tests for ForOperationResult - Update utils_test.go Test_ConvertOperation with new signature - Update all SQL INSERT statements in test files to include result_code and successful columns

Fix lint error: rename stringForExtendFootprintTtlResult to stringFor…

4743242

…ExtendFootprintTTLResult

Update codes_test.go

eb6ef8b

Update client

c45f43f

Make method private

be4730f

Update data_validation_test.go

4ee82be

Add tests for test coverage

046c21d

aditya1702 marked this pull request as ready for review January 30, 2026 17:37

aditya1702 requested a review from Copilot January 30, 2026 17:37

Copilot started reviewing on behalf of aditya1702 January 30, 2026 17:38 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

aditya1702 and others added 5 commits January 30, 2026 13:09

Update internal/integrationtests/data_validation_test.go

a649a77

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update internal/indexer/processors/codes.go

70560a4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update internal/indexer/processors/codes.go

efc523b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix tests

4bf73d1

Update 2025-06-10.3-create_indexer_table_operations.sql

6474758

aristidesstaffieri approved these changes Jan 30, 2026

View reviewed changes

Base automatically changed from result-xdr to main February 4, 2026 14:33

Merge branch 'main' into store-failed-ops

c44fdce

aditya1702 merged commit 13c0444 into main Feb 4, 2026
9 checks passed

aditya1702 deleted the store-failed-ops branch February 4, 2026 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Store failed operations along with the specific result codes#474

Store failed operations along with the specific result codes#474
aditya1702 merged 416 commits intomainfrom
store-failed-ops

aditya1702 commented Jan 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

aditya1702 Jan 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aditya1702 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Known limitations

Issue that this PR addresses

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

aditya1702 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aditya1702 commented Jan 30, 2026 •

edited

Loading