-
Notifications
You must be signed in to change notification settings - Fork 12
operations table: Store the operation_xdr as BYTEA
#497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aditya1702
wants to merge
23
commits into
hash-bytea
Choose a base branch
from
opxdr-bytea-2
base: hash-bytea
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1829d3e
Change operation_xdr column from TEXT to BYTEA
aditya1702 c844520
Add XDRBytea type for storing XDR data as BYTEA
aditya1702 b5ac8ad
Update Operation struct to use XDRBytea type
aditya1702 c23554e
Update ConvertOperation to use XDRBytea type
aditya1702 23ba111
Update operations.go for BYTEA operation_xdr storage
aditya1702 a347cc7
Add forceResolver directive to operationXdr field
aditya1702 ddaeeee
Run gql-generate and fix test_utils.go type
aditya1702 aee79f2
Implement OperationXdr GraphQL resolver
aditya1702 00eeaa3
Update tests to use XDRBytea type
aditya1702 ec34cef
Update GraphQL resolver tests for XDRBytea type
aditya1702 b58b994
Fix test data to use valid base64-encoded XDR strings
aditya1702 525a59d
Change XDRBytea underlying type from string to []byte
aditya1702 5e221f7
Use MarshalBinary directly in ConvertOperation
aditya1702 ce12f8a
Simplify BatchInsert and BatchCopy in operations.go
aditya1702 52bdb28
Update utils_test.go for XDRBytea []byte type
aditya1702 5bb41f3
Update operations_test.go for XDRBytea []byte type
aditya1702 a5429a0
Update test_utils.go for XDRBytea []byte type
aditya1702 41dfbf7
Update ingest_test.go for XDRBytea []byte type
aditya1702 bd27099
Fix operations_test.go for XDRBytea []byte type
aditya1702 762593e
Fix accounts_test.go for XDRBytea []byte type
aditya1702 5f26b91
Fix transactions_test.go for XDRBytea []byte type
aditya1702 25ccec9
Update generated.go
aditya1702 b84442d
Fix XDRBytea.Scan buffer reuse bug
aditya1702 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the column type in this existing migration file won’t update already-migrated databases, so production/dev DBs that have
operation_xdrasTEXTwill keep that type and will likely break once the app starts insertingBYTEA. Add a new forward migration thatALTER TABLE operations ALTER COLUMN operation_xdr TYPE BYTEA USING decode(operation_xdr, 'base64')(or equivalent), and avoid rewriting already-shipped migrations.