-
Notifications
You must be signed in to change notification settings - Fork 91
Hide hidden content from screen reader for show more block #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/3.5.32
Are you sure you want to change the base?
Hide hidden content from screen reader for show more block #887
Conversation
|
🎉 Zip build complete |
…screen-reader-for-show-more-block
alaca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
ravinderk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gilbert-hernandez This pull request is not working as expected. Let me know if i am missing any step:
Your video does look like it is showing correct behavior. In my video, you can see from the 1:00 to about 1:10 mark that I mention I use the tab button and it skips over the summary excerpt straight to the "show more" button. That is expected behavior as the button is interactive, but the excerpt is not. However, you should be able to access the excerpt using your arrow keys. Starting at 1:30 in my video, I also mention that you can use the arrow keys to read the excerpt. Can you just make sure the screen reader will read the excerpt when you use the arrow keys? |
Addresses the following Jira tickets.
https://stellarwp.atlassian.net/browse/KAD-4910
https://stellarwp.atlassian.net/browse/KAD-4911
https://stellarwp.atlassian.net/browse/KAD-4912
A video of the new behavior:
show_more_accessability.mp4
The save file was updated so a deprecated file was introduced. The excerpt is created on the frontend and adds a phrase at the end of the excerpt for screen readers to activate the show more button. This extra string is localized.