Fixed 0 value causing falsy scrollTopOffset #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting scrollTopOffset to 0 would not scroll user back to the top of the page when changing route because when checking for scrollTopOffsets value, 0 would imply there wasn't one (falsy).
Author
|
Any chance of merging this? |
|
Yep, it would be nice to have this fix merged. |
|
@jthoms1 can we get this merged? |
|
looks like a legit fix |
rwaskiewicz
added a commit
that referenced
this pull request
Jun 8, 2022
this commit temporarily pins the stencil version to v2.13.0. in v2.14.0, we upgraded typescript to v4.5.4, which is now causing issues with the typings found in `@stencil/router` v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting scrollTopOffset to 0 would not scroll user back to the top of the page when changing route because when checking for scrollTopOffsets value, 0 would imply there wasn't one (falsy).