Skip to content

Feat/add solid output target#276

Closed
deleonio wants to merge 13 commits intostenciljs:mainfrom
deleonio:feat/add-solid-output-target
Closed

Feat/add solid output target#276
deleonio wants to merge 13 commits intostenciljs:mainfrom
deleonio:feat/add-solid-output-target

Conversation

@deleonio
Copy link

@deleonio deleonio commented Jul 26, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL:

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@deleonio deleonio requested review from a team July 26, 2022 20:40
@deleonio
Copy link
Author

Last PR #213

@rwaskiewicz
Copy link
Contributor

Thanks! The team will review this after we review stenciljs/core#3488

@rwaskiewicz
Copy link
Contributor

Hey @deleonio 👋

Thanks for the PR! Unfortunately at this time, we're not looking to add SolidJS support to our collection of framework wrappers. As a result, I'm going to close this PR.

However, if you're interested in maintaining a Solid output target under the Stencil Community, please feel free to open a new proposal. If not, I completely understand. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants