Make ensureConfiguration give up if cache is not synced#2
Open
MikeSpreitzer wants to merge 1 commit intostevekuznetsov:skuznets/generic-storagefrom
Open
Make ensureConfiguration give up if cache is not synced#2MikeSpreitzer wants to merge 1 commit intostevekuznetsov:skuznets/generic-storagefrom
MikeSpreitzer wants to merge 1 commit intostevekuznetsov:skuznets/generic-storagefrom
Conversation
When WATCH notification latency is high, this change replaces rapid repeates of the create with going around the outer loop (which has a delay in it).
Author
|
Tested with ... and no repeats of the sql error in the following 5 minutes. |
Author
|
See also kubernetes#107696 and kubernetes#107704 . This is probably the first of many code improvements to come from lengthening the WATCH notification latency. IMHO, correct code is not sensitive to that latency --- but I bet that we have some incorrect code. Good code will not be very noisy when that latency gets long. I am sure we have more code that is not yet up to that standard of goodness. |
stevekuznetsov
pushed a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com> fix (#2) Signed-off-by: Monis Khan <mok@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When WATCH notification latency is high, this change replaces rapid
repeates of the create with going around the outer loop (which has a
delay in it).
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: