Skip to content

#3292 Added command line option to overwrite settings in the config file#3295

Merged
arporter merged 17 commits intomasterfrom
3292_lfric_runtime_checks
Feb 4, 2026
Merged

#3292 Added command line option to overwrite settings in the config file#3295
arporter merged 17 commits intomasterfrom
3292_lfric_runtime_checks

Conversation

@hiker
Copy link
Collaborator

@hiker hiker commented Jan 22, 2026

Fixes 3292. It provides a generic option to overwrite any setting in the configuration file.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (59f796e) to head (f873e78).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3295      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         380      380              
  Lines       53949    53912      -37     
==========================================
- Hits        53927    53890      -37     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker
Copy link
Collaborator Author

hiker commented Jan 28, 2026

IT passed, ready for review.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Joerg, thanks very much for this improvement. Well done for remembering to update the docs too :-)
Just minor tidying required. I'll check the ITs if you haven't already triggered them.

@arporter
Copy link
Member

arporter commented Feb 2, 2026

I see you did run the ITs so I won't do them again just now.

@hiker
Copy link
Collaborator Author

hiker commented Feb 4, 2026

IT are green, ready for next review (I just remember, I fixed up a few existing pylint errors as well ... in case that you are wondering :) )

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for all that tidying Joerg.
Will proceed to merge.

arporter and others added 2 commits February 4, 2026 09:08
Added information about command-line flag and runtime warnings option.
@arporter
Copy link
Member

arporter commented Feb 4, 2026

Failure was only linkcheck timeout on nvidia.com so this is good to go.

@arporter arporter merged commit 854913c into master Feb 4, 2026
14 of 15 checks passed
@arporter arporter deleted the 3292_lfric_runtime_checks branch February 4, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants