(closes #3281) Increase rank in zdftke and fix solfrac issue#3309
Open
(closes #3281) Increase rank in zdftke and fix solfrac issue#3309
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3309 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 380 380
Lines 53949 53951 +2
=======================================
+ Hits 53927 53929 +2
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This is ready for a first review. One for @arporter |
Member
|
It all looks fine and it's great we can deal with the costly routine in NEMO5, However, there appears to be a performance regression for the various NEMO4 offload ITs: |
arporter
requested changes
Feb 3, 2026
Member
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
All looks good, just the performance regression to consider.
| if (isinstance(check.parent, IntrinsicCall) and | ||
| check.parent.is_inquiry and | ||
| "dim" in check.parent.argument_names): | ||
| # Inquiry intrinsics calls to a given 'dim' are still ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.