Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3311 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 380 380
Lines 53949 53953 +4
=======================================
+ Hits 53927 53931 +4
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
IT passed as well, a minor change with big impact (on selected few files ;) ) |
|
I am taking this back for now. While one case (above) seems consistent, I re-did some measurements, and I am getting some inconclusive results ... it could be that the mn416-branch that I used missed some updates to the dependency_tools? |
|
I've verified that the 'speedup' of the DA on master was caused because the references were not resolved (turned up as unknown, so DA aborted early). Resolving the symbol fixes the 'speedup' (which marked the loop as not parallelisable, even though it is), it is then slow again with the correct result, and this patch fixes it: |
|
Looks like no changes, so IT do not run again. Ready to go. Note that there are still some outliers when running the DA on ukca. I've added some additional potential improvements to #3183 (#3183 (comment)) |
Delivers significant speedup in the dependency analysis for files that have many array indices that just use a simple reference as index (
a(i,j), nota(i+1, h)) by avoiding calling sympy in these simple cases.In two ukca files some loops are 30 to over 40 times faster (measurements in #3310).