(Closes #3314) fix line limit bug for in-line comments#3316
(Closes #3314) fix line limit bug for in-line comments#3316
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 380 380
Lines 53912 53933 +21
=======================================
+ Hits 53890 53911 +21
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've fired off the ITs. One for @LonelyCat124, @hiker or @sergisiso to review :-) |
| @@ -143,18 +140,17 @@ def long_lines(self, fortran_in): | |||
| return False | |||
There was a problem hiding this comment.
Should long_lines also be updated? I'm not sure how hard it would be to update this to only return True for non comments/inline comments?
There was a problem hiding this comment.
At the very least the docstring and type hints should be updated.
LonelyCat124
left a comment
LonelyCat124
left a comment
There was a problem hiding this comment.
Mostly looks good to me - I had one question (depending on how complex long_lines would need to become) and one update to the documentation.
You also need to update the author list for these files.
| @@ -143,18 +140,17 @@ def long_lines(self, fortran_in): | |||
| return False | |||
There was a problem hiding this comment.
At the very least the docstring and type hints should be updated.
2 participants
No description provided.