Open
Conversation
…peration on a future value (Socket): boolean evaluation' consider how the trajdata is kept and shared? or go striaght to mapping?
…singlefiledata: cant use as_path)
6091c1b to
eacdd72
Compare
…tors_calc.outputs.structs)) in node.graph or finalstructs in wg loop
Collaborator
Author
|
Including changes described by Elliott in PR #260 |
| "source": [ | ||
| "## Results\n", | ||
| "\n", | ||
| "**Scientific**: Fine-tuned MACE model for NaCl with DFT-labeled training data (energies, forces, stresses)\n", |
Member
There was a problem hiding this comment.
I think we want to show some actual results here e.g. maybe the descriptors of the selected (and not-selected, if we scale it up) structures, and the training plots as we have in descriptors_filter_qe.ipynb?
Member
ElliottKasoar
left a comment
There was a problem hiding this comment.
Are there changes you haven't pushed? There are a few things marked as resolved with no comment or changes
Collaborator
Author
|
To do list:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #206