Skip to content

206 add md workgraph example#251

Open
JessieGould wants to merge 37 commits intostfc:mainfrom
JessieGould:206-add-MD-workgraph-example
Open

206 add md workgraph example#251
JessieGould wants to merge 37 commits intostfc:mainfrom
JessieGould:206-add-MD-workgraph-example

Conversation

@JessieGould
Copy link
Collaborator

@JessieGould JessieGould commented Nov 6, 2025

resolves #206

@JessieGould JessieGould marked this pull request as draft November 6, 2025 18:14
@JessieGould JessieGould force-pushed the 206-add-MD-workgraph-example branch from 6091c1b to eacdd72 Compare November 21, 2025 10:49
@JessieGould JessieGould marked this pull request as ready for review December 23, 2025 12:05
@JessieGould
Copy link
Collaborator Author

JessieGould commented Dec 23, 2025

Including changes described by Elliott in PR #260

@JessieGould JessieGould self-assigned this Dec 24, 2025
@JessieGould JessieGould added documentation Improvements or additions to documentation enhancement New/improved feature or request labels Dec 24, 2025
"source": [
"## Results\n",
"\n",
"**Scientific**: Fine-tuned MACE model for NaCl with DFT-labeled training data (energies, forces, stresses)\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to show some actual results here e.g. maybe the descriptors of the selected (and not-selected, if we scale it up) structures, and the training plots as we have in descriptors_filter_qe.ipynb?

@ElliottKasoar ElliottKasoar requested a review from oerc0122 January 7, 2026 14:40
Copy link
Member

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there changes you haven't pushed? There are a few things marked as resolved with no comment or changes

@JessieGould
Copy link
Collaborator Author

To do list:

  • descriptors plot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New/improved feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MD workgraph example

2 participants