MAINT: Remove date from image name#103
Conversation
|
does this actually work? Have you tested CAPI is able to pick up new images with the same name automatically? |
anish-mudaraddi
left a comment
There was a problem hiding this comment.
personally I think we shouldn't change images underneath users - could lead to issues - much prefer to state that they need to upgrade themselves
@anish-mudaraddi I don't agree. For example a user is on image v1.33.2. A CVE is released and then a patch is released so we build image v1.33.3. We would then have to tell users to move from v1.33.2->v1.33.3. Which at that point they might as well just move to v1.34 since they are doing an upgrade anyway. Whereas if we drop the date and patch from the image then they can just tell the cluster to rebuild all the nodes and the latest patch will be picked up |
|
I see your point - @DavidFair is this what we want to do? |
Agreed, if the UUID changes where an image gets re-released by accident or chance (no patch between a critical CVE fix) and CAPI/CAPO notices it will rebuild nodes (safely), but not at a "good time" for users. If you're mid-way through a 2 day course or 1 day-long auto-reduction job you're not doing to be very happy.... I can see the merit in simplifying this to how our Ubuntu and RL images are named though. Thinking about this the cases we have are:
If people don't like the idea of having a Also another problem I've just thought of using K8s versions is it's not clear which image is newer when an image is near it's from our side. E.g. is Not sure what our thoughts are, I'm on the fence as there isn't a good clean option on this so far 🤔 This KEP and doc makes me think we could drop to a single image + binary emulating older versions that are "in the supported range" once we're past v1.32. When we get everyone to 1.32+ and we test this could we could simply drop to a single image (or 2 while we get people off EOL ones) and potentially rejig our naming convention at the same time then? Our images could literally just be AFAIK our helm templates set the K8s version from |
Okay so can we drop the date but leave the patch number? |
Just thinking about
(Missed EOL on that) It means I'd be happy dropping the date, as a user can then easily tell if there's a newer image and when they're on a dead series If you're happy with this as a plan (happy to discuss it more) could you put WTTE of "the oldest minor release that's EOL from K8s should have 'eol' appended manually by running 'openstack....'" As I'm hoping to get 1.32+ and switch to a single unified image and point people to the K8s supported versions docs instead, so any tooling to do this automatically would be removed at that point too |
Removing the date from the image name. If we follow the same naming as our OS images then we can release patches to the images without making the user manually update their clusters. New nodes and replaced nodes will pick up the new image without needing to change the user-values.yaml
DavidFair
left a comment
There was a problem hiding this comment.
LGTM, hopefully we simplify it down even further in the future 🤞
Removing the date from the image name. If we follow the same naming as our OS images then we can release patches to the images without making the user manually update their clusters. New nodes and replaced nodes will pick up the new image without needing to change the user-values.yaml