Skip to content

DOC: Remove update image properties step#92

Merged
jose-caballero merged 1 commit intomainfrom
remove_image_properties_step
Jan 14, 2026
Merged

DOC: Remove update image properties step#92
jose-caballero merged 1 commit intomainfrom
remove_image_properties_step

Conversation

@khalford
Copy link
Member

As image properties are inherited from the base image, we don't need to update them ourselves. We are assuming the base image will always be correct.

As image properties are inherited from the base image, we don't need to update them ourselves. We are assuming the base image will always be correct.
Copy link
Contributor

@Dmitry-Popovichev Dmitry-Popovichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When going through these steps, I needed to export the Openstack credentials as well. So perhaps we can add that step in around the Openstack Authentication section?

# Export credentials
export OS_AUTH_URL=https://<openstack_url>:5000/v3
export OS_APPLICATION_CREDENTIAL_ID=<app_cred_id>
export OS_APPLICATION_CREDENTIAL_SECRET=<app_cred_secret>

Otherwise everything else lgtm

@jose-caballero
Copy link
Contributor

Hi @khalford
I understand this change is just to make the documentation to reflect reality, correct?

@khalford
Copy link
Member Author

When going through these steps, I needed to export the Openstack credentials as well. So perhaps we can add that step in around the Openstack Authentication section?

# Export credentials export OS_AUTH_URL=https://<openstack_url>:5000/v3 export OS_APPLICATION_CREDENTIAL_ID=<app_cred_id> export OS_APPLICATION_CREDENTIAL_SECRET=<app_cred_secret>

Otherwise everything else lgtm

@Dmitry-Popovichev You don't need to do that if you put your app cred in ~/.config/openstack/clouds.yaml clouds.yaml is the prefered way as environment variables can leak with bash scripts.

@khalford
Copy link
Member Author

Hi @khalford I understand this change is just to make the documentation to reflect reality, correct?

@jose-caballero Yes, I have removed this step because it is not needed. Detail is in the commit message and developer notes

@Dmitry-Popovichev
Copy link
Contributor

When going through these steps, I needed to export the Openstack credentials as well. So perhaps we can add that step in around the Openstack Authentication section?
# Export credentials export OS_AUTH_URL=https://<openstack_url>:5000/v3 export OS_APPLICATION_CREDENTIAL_ID=<app_cred_id> export OS_APPLICATION_CREDENTIAL_SECRET=<app_cred_secret>
Otherwise everything else lgtm

@Dmitry-Popovichev You don't need to do that if you put your app cred in ~/.config/openstack/clouds.yaml clouds.yaml is the prefered way as environment variables can leak with bash scripts.

I did think that and I'm fairly certain I had a clouds.yaml file in the correct path but when creating the image it came up with an error that I forgot to save. I'll approve this PR anyway and we can change the docs later if needs be when we create and test the remaining capi versions.

@jose-caballero jose-caballero merged commit 5832b40 into main Jan 14, 2026
10 checks passed
@jose-caballero jose-caballero deleted the remove_image_properties_step branch January 14, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants