Conversation
Grub BIOS config was never triggered as the /boot/efi exists in the generic cloud image regardless of bios or uefi boot. Also, the path to the bios grub config was incorrect and not making the grub config in the right place. With these changes the grub config should be set for both uefi and bios so that no matter what boot mode used when building the image, if the machine changes boot later on it should still have the grub config.
meoflynn
approved these changes
Jan 19, 2026
DavidFair
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grub BIOS config was never triggered as the /boot/efi exists in the generic cloud image regardless of bios or uefi boot. Also, the path to the bios grub config was incorrect and not making the grub config in the right place. With these changes the grub config should be set for both uefi and bios so that no matter what boot mode used when building the image, if the machine changes boot later on it should still have the grub config.
I have tested with both BIOS and UEFI booted images.