Conversation
As the fields for the end of the downtimes are optional, always one of them will be left blank on the web form. StackStorm doesn't process them as an empty string, but as None. Therefore, we can not just try "strip()" on their values without checking first they are not a None one.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 109 109
Lines 2638 2640 +2
Branches 329 331 +2
=======================================
+ Hits 2633 2635 +2
Misses 4 4
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DavidFair
force-pushed
the
check_nonetype
branch
2 times, most recently
from
b1f4865 to
ace90f1
Compare
Adds unit tests to ensure that None types can be handled correctly before we try to perform string operations on them
DavidFair
force-pushed
the
check_nonetype
branch
from
ace90f1 to
15d598e
Compare
Collaborator
|
@jose-caballero Are you happy with the unit tests I've added? Just so I'm not approving my own stuff The remaining code LGTM so I'll approve that |
DavidFair
approved these changes
Jan 28, 2026
gmatthews20
reviewed
Jan 29, 2026
gmatthews20
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the fields for the end of the downtimes are optional, always one of them will be left blank on the web form. StackStorm doesn't process them as an empty string, but as None. Therefore, we can not just try "strip()" on their values without checking first they are not a None one.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?