Replace deprected pk_reources with importlib.metadata#94
Open
kalteslicht wants to merge 1 commit intostianaske:masterfrom
Open
Replace deprected pk_reources with importlib.metadata#94kalteslicht wants to merge 1 commit intostianaske:masterfrom
kalteslicht wants to merge 1 commit intostianaske:masterfrom
Conversation
epenet
reviewed
Feb 9, 2026
Comment on lines
+1
to
+22
| from typing import TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: | ||
| # During type checking, we assume the standard library interface is available | ||
| from importlib.metadata import PackageNotFoundError, version | ||
| else: | ||
| # At runtime, use stdlib importlib.metadata if available, otherwise fall back | ||
| try: | ||
| from importlib.metadata import PackageNotFoundError, version | ||
| except ImportError: | ||
| try: | ||
| from importlib_metadata import PackageNotFoundError, version # backport | ||
| except ImportError: | ||
| # Final fallback: provide minimal stubs | ||
| class PackageNotFoundError(Exception): | ||
| """Fallback exception used when metadata backends are unavailable.""" | ||
| pass | ||
|
|
||
| def version(_dist_name: str) -> str: | ||
| """Fallback version() that always raises PackageNotFoundError.""" | ||
| raise PackageNotFoundError(f"Package '{_dist_name}' not found") | ||
|
|
Contributor
There was a problem hiding this comment.
I don't think the fallback is necessary
Suggested change
| from typing import TYPE_CHECKING | |
| if TYPE_CHECKING: | |
| # During type checking, we assume the standard library interface is available | |
| from importlib.metadata import PackageNotFoundError, version | |
| else: | |
| # At runtime, use stdlib importlib.metadata if available, otherwise fall back | |
| try: | |
| from importlib.metadata import PackageNotFoundError, version | |
| except ImportError: | |
| try: | |
| from importlib_metadata import PackageNotFoundError, version # backport | |
| except ImportError: | |
| # Final fallback: provide minimal stubs | |
| class PackageNotFoundError(Exception): | |
| """Fallback exception used when metadata backends are unavailable.""" | |
| pass | |
| def version(_dist_name: str) -> str: | |
| """Fallback version() that always raises PackageNotFoundError.""" | |
| raise PackageNotFoundError(f"Package '{_dist_name}' not found") | |
| from importlib.metadata import PackageNotFoundError, version | |
Contributor
|
@stianaske have you seen this PR?
See home-assistant/core#162611 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use a fork of the homeassistant-vorwerk custom integration in Home Assistant which uses pybotvac as a dependency and noticed this warning in the logs:
These changes should fix the problem.