Skip to content

Conversation

@venik
Copy link
Contributor

@venik venik commented Jul 29, 2025

Adds compiler agnostic way to check c++ dialect via ASL_CPP_VERSION. adobe/arg_stream.hpp was slightly fixed and now compiles with XCode/MSVS, also some unittests were provided

@@ -0,0 +1,3 @@
project adobe/arg_stream ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using bjam anymore, so no need for this file.

#include <boost/test/unit_test.hpp>

// asl
#include <adobe/arg_stream.hpp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the first file included to test that there are no hidden dependencies.

@venik venik requested a review from sean-parent July 30, 2025 19:41
Copy link
Member

@sean-parent sean-parent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-parent sean-parent merged commit 08845b7 into stlab:main Jul 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants