Skip to content

fix: get project compiled on msvc and clang #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FelixPetriconi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: get project compiled on msvc and clang #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63636e
fix: get project compiled on msvc and clang
FelixPetriconi Nov 4, 2025
58bb11a
Remove cli as dependency because it is not needed and the referenced
FelixPetriconi Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ endif()
cpmaddpackage("gh:catchorg/Catch2@3.3.2")
endif()

if(NOT TARGET CLI11::CLI11)
cpmaddpackage("gh:CLIUtils/CLI11@2.3.2")
endif()

if(NOT TARGET ftxui::screen)
cpmaddpackage("gh:ArthurSonzogni/FTXUI#e23dbc7473654024852ede60e2121276c5aab660")
endif()
Expand Down
2 changes: 1 addition & 1 deletion cmake/CompilerWarnings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function(
set(CLANG_WARNINGS
-Wall
-Wextra # reasonable and standard
-Wshadow # warn the user if a variable declaration shadows one from a parent context
#-Wshadow # warn the user if a variable declaration shadows one from a parent context
-Wnon-virtual-dtor # warn the user if a class with virtual functions has a non-virtual destructor. This helps
# catch hard to track down memory errors
-Wold-style-cast # warn for c-style casts
Expand Down
4 changes: 4 additions & 0 deletions cmake/StandardProjectSettings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ else()
message(STATUS "No colored compiler diagnostic set for '${CMAKE_CXX_COMPILER_ID}' compiler.")
endif()

# Enable __cplusplus makro on MSVC which is disabled by default
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:/Zc:__cplusplus>)
endif()

# run vcvarsall when msvc is used
include("${CMAKE_CURRENT_LIST_DIR}/VCEnvironment.cmake")
Expand Down
4 changes: 2 additions & 2 deletions test/initial_draft.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class chain {
/// for computing the result type of this chain.
static consteval auto result_type_helper(Tail&& tail, segment<Applicator, Fs...>&& head) {
return detail::fold_over(
[](auto fold, auto&& first, auto&&... rest) {
[]([[maybe_unused]] auto fold, auto&& first, auto&&... rest) {
if constexpr (sizeof...(rest) == 0) {
return [_segment = STLAB_FWD(first)](auto&&... args) mutable {
return std::move(_segment).result_type_helper(STLAB_FWD(args)...);
Expand All @@ -141,7 +141,7 @@ class chain {
template <class R>
auto expand(const R& receiver) && {
return detail::fold_over(
[receiver](auto fold, auto&& first, auto&&... rest) {
[receiver]([[maybe_unused]] auto fold, auto&& first, auto&&... rest) {
if constexpr (sizeof...(rest) == 0) {
return [receiver,
_segment = STLAB_FWD(first).append(receiver)](auto&&... args) mutable {
Expand Down
Loading