Streamlining of sunrise operation#8
Open
kevincoleman wants to merge 14 commits intostockmopar:masterfrom
kevincoleman:master
Open
Streamlining of sunrise operation#8kevincoleman wants to merge 14 commits intostockmopar:masterfrom kevincoleman:master
kevincoleman wants to merge 14 commits intostockmopar:masterfrom
kevincoleman:master
Conversation
… for smoother sunrise; added minutesOfSunrise for easier user input (in minutes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just made the fading more gradual, and reorganized where the millisecond math takes place. Going 1% at a time limits the max speed of fade on (lots of requests), but I figure most people wouldn’t want to fade on faster than over about 10 min.