fix(cli): require value for space info --space and add input validation#428
Open
n3-rd wants to merge 2 commits intostoracha:mainfrom
Open
fix(cli): require value for space info --space and add input validation#428n3-rd wants to merge 2 commits intostoracha:mainfrom
space info --space and add input validation#428n3-rd wants to merge 2 commits intostoracha:mainfrom
Conversation
Dhruv-Varshney-developer
approved these changes
Sep 23, 2025
Member
Dhruv-Varshney-developer
left a comment
Dhruv-Varshney-developer
left a comment
There was a problem hiding this comment.
Interesting. Thanks!
travis
requested changes
Sep 24, 2025
| */ | ||
| export async function spaceInfo(opts) { | ||
| const client = await getClient() | ||
| if (typeof opts.space === 'boolean') { |
Member
There was a problem hiding this comment.
the error message here is wrong - --space does not require a value, it defaults to the currently selected space unless you specify a DID. I'd remove this whole clause - if space is given as a boolean it will be caught below in the other new check you added
travis
requested changes
Sep 24, 2025
Co-authored-by: Travis Vachon <travis.vachon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--spaceforspace infoaccept a required value (<did>)--spaceis provided without a value, and emit a clear usage error.Why
Currently
space info --space(or-s) without a value setsopts.space === true. The handler then treatstruelike a DID and passes it into the client, producing a runtime error:This should be fixed as