-
Notifications
You must be signed in to change notification settings - Fork 28
[Mainnet] Non Fungible Token Contract #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
YakupIpek
wants to merge
5
commits into
stratisproject:master
from
YakupIpek:Mainnet-Non-Fungible-Token-Contract
Closed
[Mainnet] Non Fungible Token Contract #28
YakupIpek
wants to merge
5
commits into
stratisproject:master
from
YakupIpek:Mainnet-Non-Fungible-Token-Contract
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtpain
reviewed
Dec 31, 2020
mrtpain
reviewed
Dec 31, 2020
mrtpain
reviewed
Dec 31, 2020
mrtpain
reviewed
Dec 31, 2020
mrtpain
requested changes
Dec 31, 2020
Collaborator
mrtpain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think we need to look into the use of Interfaces and real world uses with this contract.
- NextTokenId is never actually incremented
- OnNonFungibleTokenReceived is not a method anywhere
- Curious how much actual testing this has been done with and what the gas costs might be for some of these happy paths. There's a lot going on in a single action, thinking about 100,000 gas limits per transaction here, with callbacks / other contract integrations there needs to be sufficient room.
mrtpain
reviewed
Jan 26, 2021
mrtpain
reviewed
Jan 26, 2021
mrtpain
reviewed
Jan 26, 2021
mrtpain
reviewed
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-Fungible Token Token Contract
Compiler Version
Contract Hash
Contract Byte Code