refactor: Enable noImplicitOverride on the remaining non-generated code

packages/autocertifier-client/tsconfig.generated.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}

packages/autocertifier-client/tsconfig.json

@@ -1,14 +1,13 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
-    "src",
-    "generated"
+    "src"
   ],
   "references": [
-    { "path": "../utils" }
+    { "path": "../utils" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/autocertifier-server/tsconfig.json

@@ -8,9 +8,9 @@
     "bin"
   ],
   "references": [
+    { "path": "../utils" },
     { "path": "../autocertifier-client" },
-    { "path": "../dht" },
     { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../dht" }
   ]
 }

packages/cli-tools/tsconfig.json

@@ -10,9 +10,9 @@
     "bin"
   ],
   "references": [
+    { "path": "../utils" },
     { "path": "../dht" },
-    { "path": "../sdk" },
     { "path": "../trackerless-network" },
-    { "path": "../utils" }
+    { "path": "../sdk" }
   ]
 }

packages/dht/package.json

@@ -26,7 +26,7 @@
     "postbuild": "./scripts/postbuild.sh",
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
     "test": "npm run test-unit && npm run test-integration && npm run test-end-to-end",

packages/dht/test/unit/PeerManager.test.ts

@@ -17,7 +17,7 @@ const createDhtNodeRpcRemote = (
 ) => {
     const remote = new class extends DhtNodeRpcRemote {
         // eslint-disable-next-line class-methods-use-this
-        async ping(): Promise<boolean> {
+        override async ping(): Promise<boolean> {
             return !pingFailures.has(toNodeId(peerDescriptor))
         }
     }(localPeerDescriptor, peerDescriptor, undefined as any, new MockRpcCommunicator())

packages/dht/test/utils/utils.ts

@@ -62,7 +62,7 @@ export const createMockRingNode = async (
         rpcRequestTimeout: 5000
     }
     const node = new class extends DhtNode {
-        async stop(): Promise<void> {
+        override async stop(): Promise<void> {
             await super.stop()
             await mockConnectionManager.stop()
         }
@@ -90,7 +90,7 @@ export const createMockConnectionDhtNode = async (
         rpcRequestTimeout: 5000
     }
     const node = new class extends DhtNode {
-        async stop(): Promise<void> {
+        override async stop(): Promise<void> {
             await super.stop()
             await mockConnectionManager.stop()
         }

packages/dht/tsconfig.generated.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}

packages/dht/tsconfig.jest.json

@@ -1,13 +1,12 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "test",
     "package.json",
     "scripts"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/dht/tsconfig.json

@@ -1,19 +1,18 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
     "src",
-    "generated",
     "package.json"
   ],
   "references": [
-    { "path": "../autocertifier-client" },
+    { "path": "../utils" },
+    { "path": "../proto-rpc" },
     { "path": "../cdn-location" },
     { "path": "../geoip-location" },
-    { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../autocertifier-client" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/proto-rpc/package.json

@@ -21,7 +21,7 @@
     "prebuild": "./proto.sh",
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
-    "check": "./test-proto.sh && tsc -p tsconfig.jest.json",
+    "check": "./test-proto.sh && tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "./test-proto.sh && eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",
     "test": "./test-proto.sh && npm run test-unit && npm run test-integration",

packages/proto-rpc/tsconfig.generated.json

@@ -0,0 +1,11 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated",
+    "test/proto"
+  ],
+  "exclude": []
+}

packages/proto-rpc/tsconfig.jest.json

@@ -1,11 +1,13 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "test"
+  ],
+  "exclude": [
+    "test/proto"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/proto-rpc/tsconfig.json

@@ -1,14 +1,13 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
-    "src",
-    "generated"
+    "src"
   ],
   "references": [
-    { "path": "../utils" }
+    { "path": "../utils" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/sdk/package.json

@@ -36,7 +36,7 @@
     "build-browser": "npm run build-browser-development && npm run build-browser-production",
     "build-browser-development": "NODE_ENV=development webpack --mode=development --progress",
     "build-browser-production": "NODE_ENV=production webpack --mode=production --progress",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache || true; rm -rf dist src/generated *.tsbuildinfo node_modules/.cache || true",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts,mts}'",
     "generate-protoc-code": "./proto.sh",

packages/sdk/src/identity/EthereumKeyPairIdentity.ts

@@ -26,7 +26,7 @@ export class EthereumKeyPairIdentity extends KeyPairIdentity {
         return signingUtil.createSignature(payload, this.privateKey)
     }
 
-    async getTransactionSigner(rpcProviderSource: RpcProviderSource): Promise<SignerWithProvider> {
+    override async getTransactionSigner(rpcProviderSource: RpcProviderSource): Promise<SignerWithProvider> {
         const primaryProvider = rpcProviderSource.getProvider()
         return new Wallet(binaryToHex(this.privateKey), primaryProvider) as SignerWithProvider
     }

packages/sdk/tsconfig.generated.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "src/generated"
+  ],
+  "exclude": []
+}

packages/sdk/tsconfig.jest.json

@@ -3,8 +3,7 @@
   "compilerOptions": {
     "lib": ["es2021"],
     "experimentalDecorators": true,
-    "emitDecoratorMetadata": true,
-    "noImplicitOverride": false
+    "emitDecoratorMetadata": true
   },
   "include": [
     "package.json",
@@ -16,6 +15,10 @@
     "scripts"
   ],
   "exclude": [
+    "src/generated",
     "test/exports"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/sdk/tsconfig.json

@@ -5,20 +5,21 @@
     "declarationDir": "dist/types",
     "lib": ["es2021"],
     "experimentalDecorators": true,
-    "emitDecoratorMetadata": true,
-    "noImplicitOverride": false
+    "emitDecoratorMetadata": true
   },
   "include": [
     "src",
     "src/**/*.json"
   ],
   "exclude": [
+    "src/generated",
     "src/exports-esm.mjs"
   ],
   "references": [
-    { "path": "../dht" },
+    { "path": "../utils" },
     { "path": "../proto-rpc" },
+    { "path": "../dht" },
     { "path": "../trackerless-network" },
-    { "path": "../utils" }
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/trackerless-network/package.json

@@ -20,7 +20,7 @@
     "build": "tsc -b",
     "build-browser": "webpack --mode=development --progress",
     "prebuild": "./proto.sh",
-    "check": "tsc -p tsconfig.jest.json",
+    "check": "tsc -b tsconfig.jest.json",
     "clean": "jest --clearCache || true; rm -rf dist generated *.tsbuildinfo node_modules/.cache || true",
     "coverage": "jest --coverage",
     "eslint": "eslint --cache --cache-location=node_modules/.cache/.eslintcache/ '*/**/*.{js,ts}'",

packages/trackerless-network/tsconfig.generated.json

@@ -0,0 +1,10 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "noImplicitOverride": false
+  },
+  "include": [
+    "generated"
+  ],
+  "exclude": []
+}

packages/trackerless-network/tsconfig.jest.json

@@ -1,12 +1,11 @@
 {
   "extends": "../../tsconfig.jest.json",
-  "compilerOptions": {
-    "noImplicitOverride": false
-  },
   "include": [
     "src",
-    "generated",
     "package.json",
     "test"
+  ],
+  "references": [
+    { "path": "./tsconfig.generated.json" }
   ]
 }

packages/trackerless-network/tsconfig.json

@@ -1,17 +1,16 @@
 {
   "extends": "../../tsconfig.node.json",
   "compilerOptions": {
-    "outDir": "dist",
-    "noImplicitOverride": false
+    "outDir": "dist"
   },
   "include": [
     "src",
-    "generated",
     "package.json"
   ],
   "references": [
-    { "path": "../dht" },
+    { "path": "../utils" },
     { "path": "../proto-rpc" },
-    { "path": "../utils" }
+    { "path": "../dht" },
+    { "path": "./tsconfig.generated.json" }
   ]
 }