This repository was archived by the owner on Apr 8, 2021. It is now read-only.
Replace Finatra 1.6 with finagle-http, fix quick start and examples#100
Open
travisbrown wants to merge 8 commits intostripe-archive:masterfrom
Open
Replace Finatra 1.6 with finagle-http, fix quick start and examples#100travisbrown wants to merge 8 commits intostripe-archive:masterfrom
travisbrown wants to merge 8 commits intostripe-archive:masterfrom
Conversation
9dd4fc8 to
fc4502e
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes @eightysteele's changes from #95 but rebased and with a few little fixes for recent updates.
It also replaces brushfire-finatra with brushfire-finagle, which does more or less the same thing but without the dependency on the EOL-ed Finatra 1 (which won't be published for 2.12). Since this is just an example project (that wasn't compiling anyway) I figured a pretty major change wouldn't be a problem. We could also just delete the dead code, but it seems like a nice thing to have.
I've added an
./iris-srvexample to the README, since it works again. I'd like to aggregate the module in the build, so that we know when it breaks, but because the latest Finagle version isn't built for 2.10 this causes problems for++and+(we could use sbt-doge to fix this but in my experience it's a pain and in this case probably isn't worth the effort).More generally it seems like it'd be a good idea to pull all of the example code into a new brushfire-example module, so that stuff like
local.Exampleisn't ending up in our published artifacts. If people agree I could do that in this PR, or in a follow-up.