Skip to content

Conversation

@KeziahMoselle
Copy link
Contributor

@KeziahMoselle KeziahMoselle commented Mar 20, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR aims to convert our Vue.js library vue-mapbox-gl to JS toolkit based components for ease of use and without the need to load Vue.js for a simple map.

To-do

  • MapboxMap
  • MapboxMarker
  • MapboxPopup
  • MapboxNavigationControl
  • Map events
  • Handling of data: images, layers, sources (might not be useful as components)
  • MapboxCluster
  • StoreLocator

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

@KeziahMoselle KeziahMoselle linked an issue Mar 20, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Mar 20, 2024

Export Size

@studiometa/ui

Name Size Diff
MapboxMap 1.1 kB +1.1 kB (+100.00%) πŸ”Ί
MapboxMarker 1.09 kB +1.09 kB (+100.00%) πŸ”Ί
MapboxPopup 1.08 kB +1.08 kB (+100.00%) πŸ”Ί
MapboxGeolocateControl 370 B +370 B (+100.00%) πŸ”Ί
MapboxGeocoder 356 B +356 B (+100.00%) πŸ”Ί
MapboxNavigationControl 347 B +347 B (+100.00%) πŸ”Ί
Unchanged

@studiometa/ui

Name Size Diff
AbstractFrameTrigger 1.55 kB -
AbstractPrefetch 366 B -
AbstractScrollAnimation 3.35 kB -
AbstractSliderChild 600 B -
Accordion 1.77 kB -
AccordionItem 1.75 kB -
Action 1.01 kB -
AnchorNav 3.49 kB -
AnchorNavLink 3.37 kB -
AnchorNavTarget 125 B -
AnchorScrollTo 2.38 kB -
animationScrollWithEase 648 B -
CircularMarquee 543 B -
Cursor 650 B -
DataBind 653 B -
DataComputed 795 B -
DataEffect 771 B -
DataModel 731 B -
Draggable 1.36 kB -
Figure 1.51 kB -
FigureShopify 1.77 kB -
FigureTwicpics 2.05 kB -
FigureVideo 1.66 kB -
FigureVideoTwicpics 2.24 kB -
Frame 3.18 kB -
FrameAnchor 1.63 kB -
FrameForm 1.73 kB -
FrameLoader 1.24 kB -
FrameTarget 1.42 kB -
FrameTriggerLoader 1.26 kB -
Hoverable 947 B -
LargeText 707 B -
LazyInclude 322 B -
Menu 2.12 kB -
MenuBtn 140 B -
MenuList 1.7 kB -
Modal 1.99 kB -
ModalWithTransition 2.09 kB -
Panel 2.37 kB -
PrefetchWhenOver 408 B -
PrefetchWhenVisible 417 B -
ScrollAnimation 3.41 kB -
ScrollAnimationChild 3.52 kB -
ScrollAnimationChildWithEase 4.07 kB -
ScrollAnimationParent 3.59 kB -
ScrollAnimationWithEase 3.95 kB -
ScrollReveal 1.43 kB -
Sentinel 129 B -
Slider 2.33 kB -
SliderBtn 817 B -
SliderCount 650 B -
SliderDots 1.66 kB -
SliderDrag 269 B -
SliderItem 994 B -
SliderProgress 958 B -
Sticky 771 B -
Tabs 1.38 kB -
Target 86 B -
Transition 1.2 kB -
withDeprecation 166 B -
withTransition 1.19 kB -

@titouanmathis titouanmathis changed the title Add MapboxMap, MapboxMarker, MapboxPopup components [Feature] Add MapboxMap, MapboxMarker, MapboxPopup components Apr 17, 2024
@titouanmathis titouanmathis force-pushed the feature/mapboxmap-and-markers branch from c135f0f to f26c1ce Compare July 25, 2025 16:42
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 85.76159% with 43 lines in your changes missing coverage. Please review.
βœ… Project coverage is 88.44%. Comparing base (4f8e8f1) to head (18cbd29).

Files with missing lines Patch % Lines
packages/ui/MapboxMap/MapboxLayer.ts 4.16% 23 Missing ⚠️
packages/ui/MapboxMap/utils.ts 17.64% 14 Missing ⚠️
packages/ui/MapboxMap/AbstractMapboxMapChild.ts 40.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #184      +/-   ##
=============================================
- Coverage      88.68%   88.44%   -0.24%     
  Complexity        20       20              
=============================================
  Files             99      109      +10     
  Lines           3455     3757     +302     
  Branches         476      484       +8     
=============================================
+ Hits            3064     3323     +259     
- Misses           391      434      +43     
Flag Coverage Ξ”
unittests 88.44% <85.76%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MapboxMap] component

3 participants