Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 83.66% 83.65% -0.01%
==========================================
Files 152 152
Lines 4896 4894 -2
Branches 853 853
==========================================
- Hits 4096 4094 -2
Misses 498 498
Partials 302 302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bencher Report| Branch | refactor/better-coroutine-scope |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| com.apurebase.kgraphql.RequestCachingBenchmark.invalidRequest | Throughput operations / second (ops/s) x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 35.42 ops/s x 1e3(-83.92%)Baseline: 220.31 ops/s x 1e3 | 126.24 ops/s x 1e3 (356.41%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|---|---|---|
| com.apurebase.kgraphql.FunctionExecutionBenchmark.benchmarkFunctionExecution | 📈 view plot 🚷 view threshold | 6,078,408.66 ops/s(+1.69%)Baseline: 5,977,390.47 ops/s | 5,507,281.10 ops/s (90.60%) | |||
| com.apurebase.kgraphql.ParallelExecutionBenchmark.queryBenchmark | 📈 view plot 🚷 view threshold | 768.99 ms(-0.21%)Baseline: 770.63 ms | 772.70 ms (99.52%) | |||
| com.apurebase.kgraphql.QueryBenchmark.largeList | 📈 view plot 🚷 view threshold | 4.42 ops/s(+51.59%)Baseline: 2.92 ops/s | -4.54 ops/s (-102.79%) | |||
| com.apurebase.kgraphql.QueryBenchmark.manyChildren | 📈 view plot 🚷 view threshold | 159.60 ops/s(-14.36%)Baseline: 186.36 ops/s | 135.74 ops/s (85.05%) | |||
| com.apurebase.kgraphql.QueryBenchmark.manyDataChildren | 📈 view plot 🚷 view threshold | 8.80 ops/s(-1.51%)Baseline: 8.93 ops/s | 8.66 ops/s (98.42%) | |||
| com.apurebase.kgraphql.QueryBenchmark.manyOperations | 📈 view plot 🚷 view threshold | 257.23 ops/s(-1.96%)Baseline: 262.37 ops/s | 151.96 ops/s (59.08%) | |||
| com.apurebase.kgraphql.QueryBenchmark.nestedObject | 📈 view plot 🚷 view threshold | 8,809.67 ops/s(+4.41%)Baseline: 8,437.38 ops/s | 6,022.97 ops/s (68.37%) | |||
| com.apurebase.kgraphql.RequestCachingBenchmark.invalidRequest | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 35,420.50 ops/s(-83.92%)Baseline: 220,309.98 ops/s | 126,242.23 ops/s (356.41%) | |||
| com.apurebase.kgraphql.RequestCachingBenchmark.largeRequest | 📈 view plot 🚷 view threshold | 8,563.10 ops/s(+1.46%)Baseline: 8,439.89 ops/s | 7,623.27 ops/s (89.02%) | |||
| com.apurebase.kgraphql.RequestCachingBenchmark.smallRequest | 📈 view plot 🚷 view threshold | 12,924.17 ops/s(+2.00%)Baseline: 12,671.36 ops/s | 11,155.95 ops/s (86.32%) | |||
| com.apurebase.kgraphql.SimpleExecutionOverheadBenchmark.benchmark | 📈 view plot 🚷 view threshold | 459,765.69 ops/s(-2.18%)Baseline: 470,010.79 ops/s | 455,828.82 ops/s (99.14%) |
stuebingerb
force-pushed
the
refactor/better-coroutine-scope
branch
from
f44e1ee to
fb92944
Compare
Owner
Author
|
Performance regression needs further analysis |
Remove coroutineContext from execution context and use one with the provided dispatcher.
stuebingerb
force-pushed
the
refactor/better-coroutine-scope
branch
from
fb92944 to
8e4332d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove coroutineContext from execution context and use one with the provided dispatcher.