Skip to content

Conversation

@lncrd
Copy link

@lncrd lncrd commented Feb 21, 2025

I'd love to be able to use the *_of_slice variants without manually using patch.crates-io.

This PR updates murmur3 to version 0.6.0 for a new crates.io release.

Changes since the last release include adding non-copying implementations: https://github.com/stusmall/murmur3/compare/75a1128f95bb0d64e304646e453a6e18f831bebf..master

facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Jul 10, 2025
Summary:
Upstream PR stusmall/murmur3@3cd2e2f

There are other unanswered PR from Feb stusmall/murmur3#24 and last approved is from Sep 2024 so I don't want to waste to much time waiting for upstream before realizing the performance win in this stack.

The changes only introduce new functions without changing existing functionality.

Reviewed By: dtolnay

Differential Revision: D77968925

fbshipit-source-id: 673ba0aa3e0059bbc35220ddd99b814695b7ee63
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Jul 10, 2025
Summary:
Upstream PR stusmall/murmur3@3cd2e2f

There are other unanswered PR from Feb stusmall/murmur3#24 and last approved is from Sep 2024 so I don't want to waste to much time waiting for upstream before realizing the performance win in this stack.

The changes only introduce new functions without changing existing functionality.

Reviewed By: dtolnay

Differential Revision: D77968925

fbshipit-source-id: 673ba0aa3e0059bbc35220ddd99b814695b7ee63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant