Enable localhost reverse proxy serving#3422
Open
everyplace wants to merge 6 commits intosubscriptions-project:mainfrom
Open
Enable localhost reverse proxy serving#3422everyplace wants to merge 6 commits intosubscriptions-project:mainfrom
everyplace wants to merge 6 commits intosubscriptions-project:mainfrom
Conversation
everyplace
force-pushed
the
feature/reverse-proxy
branch
from
c88ecc2 to
0f9666f
Compare
everyplace
force-pushed
the
feature/reverse-proxy
branch
from
0f9666f to
f2944bf
Compare
everyplace
commented
Feb 14, 2024
gulpfile.js
Outdated
| } | ||
|
|
||
| const $$ = require('gulp-load-plugins')(); | ||
| const dotenv = require('dotenv').config(); // eslint-disable-line |
Contributor
Author
There was a problem hiding this comment.
Because dotenv runs immediately to read .env files if available, it does not need to be used after creation. As this violates the eslint/no-unused-vars rule, I've disabled it for this line.
Collaborator
There was a problem hiding this comment.
Would removing the const dotenv = part work too?
Contributor
Author
There was a problem hiding this comment.
@ChrisAntaki I tested this, and it still worked fine, so I've removed it in 78a6d31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves some changes from the stand-alone
scenic-demorepo to the embedded version within this repo. These changes allow for running the local app behind a reverse proxy, which can be of benefit for some development environments. The changes migrate only some of the changes from PR #217, as that PR handled two things:This smaller PR only does the first of those two tasks.