feat: complete ESM core implementation with 100% IIFE compatibility#3978
Draft
everyplace wants to merge 5 commits intosubscriptions-project:mainfrom
Draft
feat: complete ESM core implementation with 100% IIFE compatibility#3978everyplace wants to merge 5 commits intosubscriptions-project:mainfrom
everyplace wants to merge 5 commits intosubscriptions-project:mainfrom
Conversation
Contributor
everyplace
commented
Feb 10, 2026
everyplace
commented
- Implemented .ready() promise and Passive-by-Default ESM logic.
- Preserved Active-by-Default IIFE logic using win.SWG array augmentation.
- Added comprehensive integration tests for ESM entry points.
- Fixed GAA/SwG global object conflict in callSwg.
- Reorganized ESM documentation.
- Implemented .ready() promise and Passive-by-Default ESM logic. - Preserved Active-by-Default IIFE logic using win.SWG array augmentation. - Added comprehensive integration tests for ESM entry points. - Fixed GAA/SwG global object conflict in callSwg. - Reorganized ESM documentation.
everyplace
commented
Feb 10, 2026
| "--playEnvironment=___PLAY_ENVIRONMENT___" \ | ||
| "--swgVersion=$SWG_VERSION" \ | ||
| "--target=$target" \ | ||
| "--esm" |
Contributor
Author
There was a problem hiding this comment.
Same as the above, except with the --esm flag
everyplace
commented
Feb 10, 2026
| @@ -50,15 +66,17 @@ function create_binaries_for_environment() { | |||
| shift 4 | |||
|
|
|||
| for variant in "" "-basic" "-gaa"; do | |||
Contributor
Author
There was a problem hiding this comment.
This is the same as it was before, but now just loops twice for both js and mjs
everyplace
commented
Feb 10, 2026
| apply: 'build', | ||
| generateBundle(options, bundle) { | ||
| if (options.format !== 'iife') { | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
This exits immediately because this isn't necessary for the esm builds.
everyplace
commented
Feb 10, 2026
| export const ASSETS = '/assets'; | ||
| export const ADS_SERVER = 'https://pubads.g.doubleclick.net'; | ||
| export const EXPERIMENTS = ''; | ||
| export const IS_ESM = false; |
Contributor
Author
There was a problem hiding this comment.
This is set by vite.config.js, so during the build process this is either true or false, depending on vite's output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.