DinD support and additional packages #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Dockerfile to install Docker and necessary packages, and added the runner user to the docker group.
Expose Docker socket by adding volume mapping.
Updated Dockerfile to streamline package installation and ensure Docker is installed correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Docker setup to enable Docker-in-Docker support for the runner container, allowing workflows to run Docker commands inside the container. The main changes include installing Docker and related tools in the
Dockerfile, adding the runner user to the Docker group, and exposing the Docker socket in bothdocker-compose.ymlfiles.Docker installation and configuration:
docker-ce,docker-ce-cli,containerd.io,docker-buildx-plugin,docker-compose-plugin) in theDockerfile, along with required dependencies.Dockerfileto add therunneruser to thedockergroup, enabling permission to run Docker commands.Docker socket exposure in runner containers:
/var/run/docker.sockinservices:sections of bothdocker-compose.ymlanddocker-compose.dev.ymlto expose the Docker socket to the runner container. [1] [2]