Open
Conversation
- Add missing CHAINS= env var to all deployment commands - Update version references from v3.0.0 to v6.0.0-beta.1 - Add source .env requirement (multichain modifier reads env vars directly) - Document that --rpc-url flag is ignored by multichain modifier - Add CREATE2_SALT collision warning for gateway deployments - Document REGISTER_ROUTE env var and multisig workflow - Reference Safe Transaction Builder JSON generator - Fix typo in remappings.txt instruction - Remove hardcoded verifier address from example
- Rewrite README for external devs: simple EOA deploy path with REGISTER_ROUTE=true, step-by-step guide, Architecture section, deployed addresses linking to docs.succinct.xyz - Create docs/PRODUCTION_DEPLOYMENT.md for canonical gateway management by Succinct Labs (multisig flow, Safe TX Builder, phase-based process) - Update contracts/README.md to reflect current contract structure - Fix contracts/.env.example: add missing RPC_HOODI entry - Add --multi flag back to forge commands (required by multichain modifier)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures documentation for two audiences:
REGISTER_ROUTE=true, step-by-step guide, env var table, architecture section, and links to canonical deployments.RPC_HOODIentry.Also includes all changes from
docs/fix-readme-deployment-instructionsbranch (v6.0.0-beta.1 contracts, PR #61 REGISTER_ROUTE, PR #62 safe-batch-generator).Key fixes from fact-checking against code
--multiflag back to forge commands (required bymultichainmodifier'svm.createSelectFork())REGISTER_ROUTE=truepresented as the primary path for external devs (they own the gateway)Test plan
script/deploy/.env.exampleandfoundry.tomldeployments/*.json