Conversation
Owner
Author
|
Only complaint is that image uploads don't work on elinks, but text files do. Not sure why cause it seems to be okay with trying to POST the multipart/form-data, but then it complains when it gets a response? No idea. Not worth worrying about with this. |
Contributor
|
👎 nested form Also needs screenshot of new form layouts. |
js/index.js
Outdated
Contributor
There was a problem hiding this comment.
move this to clear. or somewhere other than here.
sudokode
force-pushed
the
fix/noscript-file-upload
branch
from
f649061 to
c15b494
Compare
index.html
Outdated
Contributor
There was a problem hiding this comment.
This needs to be in a new column, and needs class="form-control"
Contributor
There was a problem hiding this comment.
👎 inline styles == no; use bootstrap
Contributor
|
I dislike this entire idea, and in particular this implementation. |
sudokode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#29
Added:
Changed:
This is currently deployed because it works.
Can also add a form for /u in the future. Working on Update and Delete forms now. This is currently live, but I'd like to hear what you think about this commit before continuing.