Skip to content

Sshin/test3 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suejung-sentry wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sshin/test3 #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61d0997
test2
suejung-sentry Aug 12, 2024
d6ee918
test commit
suejung-sentry Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ For more information, please see the links below.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not directly related to the changes, I noticed that the README ends abruptly after the FOSSA status badge. Consider adding a conclusion or a call-to-action section to make the README more engaging and informative.

Suggested change
# After the FOSSA status badge, add:
## Contributing
We welcome contributions to this project! Please see our [Contributing Guidelines](CONTRIBUTING.md) for more information on how to get started.
## License
This project is licensed under the [MIT License](LICENSE). For full details, see the LICENSE file in the repository.
---
Thank you for your interest in our project. If you have any questions or need further assistance, please open an issue or contact our team.

[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Fcodecov%2Fexample-python.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Fcodecov%2Fexample-python?ref=badge_large)

test
test2
Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling gh api from postman directly

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling gh api from postman directly 2

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing or replacing 'test2' with meaningful content. The README should contain informative details about the project rather than test-like entries.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general recommendation, ensure that all content in the README.md file is purposeful and provides value to users or contributors. Consider adding sections such as 'Getting Started', 'Prerequisites', or 'Contributing Guidelines' if they're not already present.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' doesn't provide any meaningful information. Consider removing this line entirely if it's not needed, or replace it with relevant content about the project.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: The changes made to the README.md file seem to be test or placeholder content. It's important to keep the README professional and informative. Please review the entire README to ensure it accurately represents the project and provides valuable information to users and contributors.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' seems arbitrary and doesn't provide any meaningful information. Consider removing this line entirely if it's not serving a specific purpose, or replace it with actual relevant content.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a new section to the README that provides more value to users. For example, you could include information about how to contribute to the project, a changelog, or a roadmap for future development.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' doesn't provide any meaningful information. Consider removing this line entirely if it's not needed, or replace it with actual relevant content about the project.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider reviewing the entire README file to ensure it provides comprehensive and up-to-date information about the project. A well-structured README typically includes sections such as project description, installation instructions, usage examples, and contribution guidelines.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' lacks context and purpose. Consider providing a more meaningful description or removing this line if it's not serving any specific purpose in the README.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider maintaining a consistent style for the README. If these lines are meant for testing purposes, it's recommended to remove them from the main README and use a separate test file or process instead.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' doesn't add any meaningful information to the README. Consider removing this line entirely if it's not serving a specific purpose, or replace it with relevant content that adds value to the documentation.

Suggested change
test2
# If removing:
# Delete this line
# If adding relevant content, for example:
For more detailed examples and usage instructions, please refer to our [documentation](https://example.com/docs).

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'test2' doesn't provide any meaningful information about the project. Consider removing this line or replacing it with relevant content that adds value to the README.

Suggested change
test2

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding more meaningful content to the README that provides valuable information about the project. This could include sections such as 'Getting Started', 'Usage Examples', or 'Contributing Guidelines'.

Suggested change
test2
# Getting Started
[Provide instructions on how to set up and run the project]
# Usage Examples
[Include code snippets or examples of how to use the project]
# Contributing Guidelines
[Explain how others can contribute to the project]

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made to this section of the README don't seem to add any meaningful content or value to the documentation. Consider removing these lines if they're not intended for production, or replacing them with useful information about the project.

Suggested change
test2
If these lines are not needed, consider removing them entirely:
```markdown
test2
asdf

If you intended to add information, consider replacing with something more meaningful, for example:

## Contributing

Contributions are welcome! Please see our [Contributing Guidelines](CONTRIBUTING.md) for more information on how to get started.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making changes to documentation, ensure that each modification serves a clear purpose and enhances the overall quality and usefulness of the document. Avoid adding placeholder or test content in production documentation.

Suggested change
test2

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 'test' to 'test2' doesn't add any meaningful information to the README. Consider removing this line entirely if it's not serving a specific purpose. If there's important information to convey, replace this with a clear, descriptive sentence.

Suggested change
test2

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general note, it's important to keep the README file clean, professional, and informative. These changes seem to degrade the quality of the documentation. Consider reverting these changes if they were made unintentionally, or replace them with meaningful content that adds value for users and contributors of the project.

Suggested change
test2

asdf
Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder content. Please remove this line or replace it with relevant information about the project.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder text. README files should contain clear, informative content about the project. Please remove this line or replace it with relevant information.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder text. README files should contain clear, informative content about the project. Please replace this with meaningful information or remove it if not needed.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be a placeholder or accidental input. README files should contain clear, informative content about the project. Please remove this line or replace it with meaningful documentation.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder text. Please replace this with meaningful content that adds value to the README, or remove it if it's not needed.

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or incomplete. README files should contain clear and useful information about the project. Please remove this line or replace it with meaningful content that benefits users or contributors.

Suggested change
asdf
# Remove this line entirely

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder text. It's recommended to remove this line and replace it with meaningful content that provides value to users reading the README.

Suggested change
asdf

Copy link
Owner Author

@suejung-sentry suejung-sentry Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of 'asdf' appears to be unintentional or placeholder text. README files should contain informative content about the project. Please remove this line or replace it with relevant information about the project, such as usage instructions, contribution guidelines, or additional resources.

Suggested change
asdf

Loading