Fix whitespace normalization to preserve SQL quoted strings in ERB templates #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
prepared_for_logsmethod (used for logging SQL queries) was incorrectly normalizing whitespace inside SQL quoted strings. The previous implementation inprepare_queryused a simple regex patterngsub(/(\n|\s)+/, ' ')that would:<% ... %>)This caused issues with complex ERB templates that use multiline Ruby code blocks or contain SQL string literals with intentional whitespace.
Solution
This PR refactors the
prepare_querymethod to:'...'"..."The new pattern
/'(?:[^'\\]|\\.)*'|"(?:[^"\\]|\\.)*"|(\s+)/properly handles:Changes
prepare_querymethod with improved whitespace handlingWhy This Matters
This fix is critical because:
Testing
All existing tests pass, plus new tests verify: