Open
Conversation
…python stuff. Removed functions from cryptonite_hash.h that I have not changed. Changed the cryptonight_hash function to accept a var length void pointer. Added LibTest to do a basic hash check on the string from the rfc.
…fault), a C shared library, and a C static library. The new options are MAKE_CLIB and MAKE_CLIB_STATIC. In the header and source I added a macro that picks between the C lib and the python lib.
…e defined functions for C use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original author/authors did an amazing job creating this library for python. It is easily the best one I've seen. I was working on a C program that needed the cryptonight hash function, and stumbled across this library. The only problem was that I couldn't use it because of the python hooks. I changed up the cmake file so that there is now 2 more options:
MAKE_CLIB_STATIC
MAKE_CLIB
I tried to preserve the original make file so that it does not interfere with the python lib that can be generated. The header cryptonite_hash has the macro flag CLIB that choose between the function needed for the C library and the function originally defined by the author. I hope this small change will be added to the project because it would be of great use to other C and C++ programmers.
Happy to take any criticism, always trying to improve