11.0 auditlog extension

[gfcapalbo]

@thomaspaulb first alpha

[gfcapalbo]

@tom all review fixes done and tested , found more needed features:

[ x ] version change
[ x ] removed demo data , not needed
[ x ] groups_id are not required but if fields_ids is set , we add the default res_users
[ x ] checkbox for when we select no "field_ids", to signify we have created a rule for all fields ( readonly compute, just for clarity)
[ x ] onchange: if model_id is changed , we MUST wipe out currently selected field_ids ( very important)
[ x ] create did not work in creating rule , now does
[ x ] refactored as requested
[ x ] domain works even when group is selected , but no fields.

[gfcapalbo]

ADDED :
now we manage the case of:
auditlog.rule with permissions, becoming a "normal" rule, we now delete the associated rules.

[gfcapalbo]

Added:
Now "subscribe" is overwritten to create the action we want. automatic generation of action , works on any model.
removed hardcoded action.

[gfcapalbo]

@tom Needed to add the automatic action as a feature:
The "subscribe" in audit log would create it's own action, after we made the /DATA /DEMO, having the hardcoded res.partner action made no more sense.
It was quick and easy to do.
We can extend it however we want.
"unsubscribe" just deletes the action.

[gfcapalbo]

removed the "all_fields" boolean , works perfectly without it.

[gfcapalbo]

@thomaspaulb

[gfcapalbo]

@thomaspaulb reminder for final approval.

[thomaspaulb]

Actually what i meant was to create two actions, view logs, and view log lines. So you can leave the "view logs" action as is. They do different things May 2, 2022 10:38:52 Giovanni Capalbo (Therp) ***@***.***>:

…

***@***.**** commented on this pull request. ---------------------------------------- In auditlog_security/models/auditlog_rule.py[#4 (comment)]: > +    def _prepare_rule_values(self): +        domain_force = "[" + " ('log_id.model_id' , '=', %s)," % (self.model_id.id) +        if self.field_ids: +            domain_force += "('field_id', 'in',  %s)" % (self.field_ids.ids) +        domain_force += "]" +        return { +            "name": "auditlog_extended_%s" % self.id, +            "model_id": self.env.ref("auditlog.model_auditlog_log_line").id, +            "groups": [(6, 0, self.group_ids.ids)], +            "perm_read": True, +            "domain_force": domain_force, +            "auditlog_id": self.id, +        } + +    @api.multi +    def subscribe(self): Ah! yes , the original is written in a way to make it un-inheritable. It creates "old" action and does not return the created action, just true. In order to preserve inheritance i should            call super            find the action it created and modify the domain with what we want. will do that ( we just have to modify all actions of the rule after calling super) and we preserve inheritance chain. — Reply to this email directly, view it on GitHub[#4 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AALF75FFONAXQZMTA2HBQLLVH6IBNANCNFSM5TGIP5TQ]. You are receiving this because you were mentioned. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AALF75FVTPDZERRHC6C2Z4DVH6IBNA5CNFSM5TGIP5T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHETLOPQ.gif]

[gfcapalbo]

@thomaspaulb added a video showing it working on issue tracker, and added some small cleanups this morning.
Ready for review, all errors/comments addressed except that 1 on security, where I explain the sense of it.

[gfcapalbo]

@thomaspaulb

• [ x ] fixed the breaking typo
• [ x ] removed useless XMLID change in "auditlog" module
• [ x ] subscribe does not delete original action, just adds new one.
• [ x ] rebuilt README

[gfcapalbo]

@thomaspaulb i don;t understand how was the CSV import removed , testing for regressions.

[gfcapalbo]

@thomaspaulb
Re-checked all open issues. rebased, only 2 commits now.

[thomaspaulb]

Closed in favour of Therp#1

(I can push there too)