Conversation
Julian88Tex
left a comment
Julian88Tex
left a comment
There was a problem hiding this comment.
Looks good. I'd do some more grouping of keywords and add in a few comments for anything that isn't apparently clear just by reading keyword
| Click Modal Button Save | ||
| Wait Until Modal Is Closed | ||
| ${gau_header}= Get Main Header | ||
| ${gau1}= Save Current Record Id For Deletion General_Accounting_Unit__c |
There was a problem hiding this comment.
I've noticed we usually use "Store Session Record" when we want to save it for deletion by suite teardown: https://github.com/SalesforceFoundation/NPSP/blob/master/robot/Cumulus/tests/browser/contacts_accounts/create_household.robot#L49
| Select Tab Related | ||
| Click Object Button New | ||
| Populate Modal Form Percent=100 | ||
| ... Campaign=&{campaign}[Name] | ||
| Click Modal Button Save |
There was a problem hiding this comment.
I'd group into keyword called Create GAU Allocation From GAU Related List
| Go To Page Listing | ||
| ... Opportunity | ||
| ${opportunity_name}= Generate Random String | ||
| Click Object Button New | ||
| Select Record Type Donation | ||
| Populate Modal Form | ||
| ... Opportunity Name=${opportunity_name} | ||
| ... Account Name=${data}[contact][LastName] Household | ||
| ... Amount=${amount} | ||
| ... Primary Campaign Source=${campaign}[Name] | ||
| Select Value From Dropdown Stage ${stage_name} | ||
| Open Date Picker Close Date | ||
| Pick Date Today | ||
| Click Modal Button Save |
There was a problem hiding this comment.
I'd group and call the keyword Create Opportunity Related to Campaign
There was a problem hiding this comment.
Agree. The key is not to show too granular user actions on the main test case unless that action is part of the test case.
| Select Tab Related | ||
| Validate Related Record Count GAU Allocations 1 No newline at end of file |
There was a problem hiding this comment.
I'd call this keyword Verify GAU Allocation is Automatically Created
rjanjanam
left a comment
rjanjanam
left a comment
There was a problem hiding this comment.
Very good Sung. I think you got the hang of it. So Where every there are a bunch of minor details user action and you think that these actions can be repeatable for other similar test scenarios, you can club them and make it as a keyword after making sure that a similar keyword does not exist.
3 participants
No description provided.