Skip to content

Conversation

@ppKrauss
Copy link

main change was from if (bits === 5) to if (bits === maxBits).

@sunng87
Copy link
Owner

sunng87 commented Nov 28, 2018

By making a new encodeBase4, I don't want to change the signature of current encode for bringing in incompatible change.

I suggest to refactoring the code to support base4 encoding.

Also please add the space between operators. And add {} to of else for consistency of coding style.

@ppKrauss
Copy link
Author

By making a new encodeBase4, I don't want to change the signature of current encode for bringing in incompatible change.

I not see "default undefined" as a incompatible change.

I suggest to refactoring the code to support base4 encoding.

... Better you do what you whant...

Also please add the space between operators. And add {} to of else for consistency of coding style.

OK. (I think it is possible to enforce style with travis.yml)

@ppKrauss
Copy link
Author

ppKrauss commented Dec 4, 2018

Hi, some news here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants