fix: ncalls to handle > billion calls formating #4658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It fixes a "bug" when users have now
ncallsthat are higher than the billion..What is the current behavior?
It shows data like
###,###,###instead, of let's say1,123,456,789, so addingWhat is the new behavior?
It shows fixed values because the formating as gone from
to_char(calls, 'FM999G999G990') AS ncalls,to
to_char(calls, 'FM999G999G999G999G990') AS ncalls,in the source query
internal/inspect/calls/calls.sqlFeel free to include screenshots if it includes visual changes.
After the patch (and some time ofc: live database), one can see the ncalls with > 1 billion calls..
Additional context
N/A