Skip to content

Conversation

@jpargudo
Copy link
Contributor

What kind of change does this PR introduce?

It fixes a "bug" when users have now ncalls that are higher than the billion..

What is the current behavior?

It shows data like ###,###,### instead, of let's say 1,123,456,789, so adding

Capture d’écran 2025-12-23 à 09 18 33

What is the new behavior?

It shows fixed values because the formating as gone from
  to_char(calls, 'FM999G999G990') AS ncalls,
to
to_char(calls, 'FM999G999G999G999G990') AS ncalls,
in the source query internal/inspect/calls/calls.sql
Feel free to include screenshots if it includes visual changes.

After the patch (and some time ofc: live database), one can see the ncalls with > 1 billion calls..

Capture d’écran 2025-12-23 à 10 59 32

Additional context

N/A

@jpargudo jpargudo requested a review from a team as a code owner December 23, 2025 10:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20457587013

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 56.06%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 20457218033: -0.03%
Covered Lines: 6836
Relevant Lines: 12194

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1be041b into develop Dec 23, 2025
16 of 17 checks passed
@sweatybridge sweatybridge deleted the jpargudo/inspect_review branch December 23, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants