Skip to content

Conversation

@grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Dec 16, 2025

Summary

Adds support for passing additional query items to the download method in StorageFileApi, allowing users to append custom query parameters to download requests.

Motivation

This enhancement enables users to pass custom query parameters (e.g., version numbers, cache control, etc.) when downloading files from storage, providing more flexibility in how files are requested.

Changes

  • Added optional query additionalQueryItems: [URLQueryItem]? parameter to StorageFileApi.download() method
  • Query items are merged with existing transform options query items
  • Added test case testDownloadWithAdditionalQuery() to verify the functionality
  • Improved pattern matching syntax consistency (from case let .data(data): to case .data(let data):)

Testing

  • Added unit test that verifies additional query items are correctly appended to the request
  • Test verifies the query parameter version=1 is included in the download request
  • All existing tests continue to pass

Example Usage

let data = try await storage.from("bucket")
  .download(
    path: "file.txt",
    query: [URLQueryItem(name: "version", value: "1")]
  )

@grdsdev grdsdev requested a review from a team December 16, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants