Skip to content

Conversation

@Dheepthi-Reddy
Copy link

  • Design HashSet
  • MinStack

@super30admin
Copy link
Owner

  • The student's solution is well-implemented and follows best practices. The comments are helpful and the code is clean.
  • For the HashSet, the student could consider making the primary and secondary bucket sizes constants (e.g., PRIMARY_BUCKETS = 1000) to avoid magic numbers and improve readability.
  • For the MinStack, the initial min value could be set to float('inf') in Python instead of 2**31 -1 to make it more universally applicable.
  • The student could also add docstrings to the methods to explain their purpose and parameters, which would further improve code documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants