Skip to content

Comments

[Hashing based techiques]#2158

Open
takchiks wants to merge 2 commits intosuper30admin:masterfrom
takchiks:master
Open

[Hashing based techiques]#2158
takchiks wants to merge 2 commits intosuper30admin:masterfrom
takchiks:master

Conversation

@takchiks
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The solution in SubarraySum.java is correct and efficient, using the optimal approach with a hashmap.
  • The code is well-commented and easy to understand.

Areas for Improvement:

  • Avoid including multiple solutions to different problems in the same submission. Focus on the problem at hand.
  • The brute-force solution, while correct, is inefficient and should not be used for this problem due to high time complexity.
  • Ensure that the submission only contains the relevant code for the problem. Extraneous code can cause confusion and may lead to errors in evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants