Completed Pr 1

[divyaa2809]

No description provided.

[super30admin]

1. Correctness:

   • Exercise_1.py: The stack implementation using a list is correct and handles edge cases like empty stack for pop() and peek(). The show() method returns a copy, which is good practice to prevent external modifications.
   • Exercise_2.py: The linked list stack implementation is mostly correct but lacks some functionality like isEmpty(), peek(), and size() which would be expected in a complete stack implementation.
   • Exercise_3.py: The singly linked list implementation is correct for append(), find(), and remove() operations. The remove() method correctly handles the case where the key is at the head.

2. Time Complexity:

   • Exercise_1.py: Correctly documented and implemented with O(1) for most operations except show() which is O(n).
   • Exercise_2.py: push() and pop() are correctly O(1) but missing documentation.
   • Exercise_3.py: Correctly implements O(n) for append(), find(), and remove() but missing documentation.

3. Space Complexity:

   • Exercise_1.py: Correctly documented as O(n).
   • Exercise_2.py: Should be O(n) but not documented.
   • Exercise_3.py: Should be O(n) but not documented.

4. Code Quality:

   • Exercise_1.py: Well-structured and readable with good comments.
   • Exercise_2.py: Could benefit from more methods (isEmpty, peek) and comments/documentation.
   • Exercise_3.py: Good structure but could use more comments, especially for the remove() method which has non-trivial logic.

5. Efficiency:

   • Exercise_1.py: No obvious improvements needed.
   • Exercise_2.py: Could add more stack functionality for completeness.
   • Exercise_3.py: Consider adding a tail pointer to make append() O(1).

Areas for Improvement:

• Add documentation/comments for time and space complexity in Exercise_2.py and Exercise_3.py
• Complete the stack implementation in Exercise_2.py with standard methods
• Consider adding a tail pointer in Exercise_3.py for O(1) appends
• Add more comments explaining non-trivial logic, especially in remove()