Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/super-editor/src/core/commands/list-helpers/is-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ import { getResolvedParagraphProperties } from '@extensions/paragraph/resolvedPr
* @param {import("prosemirror-model").Node} n - The ProseMirror node to check.
* @returns {boolean} True if the node is an ordered or bullet list, false otherwise
*/
export const isList = (node) =>
!!node &&
node.type?.name === 'paragraph' &&
getResolvedParagraphProperties(node).numberingProperties &&
node.attrs?.listRendering;
export const isList = (node) => {
if (!node || node.type?.name !== 'paragraph') return false;

const resolvedProps = getResolvedParagraphProperties(node);
const props = resolvedProps || node.attrs?.paragraphProperties; // fall back to raw props if uncached
const numberingProps = props?.numberingProperties;

return !!numberingProps && !!node.attrs?.listRendering;
};
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ watch(activeComment, (newVal, oldVal) => {
verticalOffset.value = selectionTop - renderedTop;

setTimeout(() => {
renderedItem.elementRef.value?.scrollIntoView({
// elementRef may be stale/null after comment list re-renders
const elementRef = renderedItem.elementRef;
if (!elementRef) return;
elementRef.value?.scrollIntoView({
behavior: 'smooth',
block: 'center',
});
Expand Down
Loading