Open
Conversation
- Added telemetry support to track document opens for usage-based billing. - Introduced `initTelemetry` method in the Editor class to initialize telemetry based on configuration. - Created tests for telemetry functionality, ensuring correct behavior when enabled/disabled and with various configurations. - Updated Editor and SuperDoc configurations to include telemetry options and license key handling. - Enhanced SuperConverter to manage document creation timestamps for unique identification.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64ce62e12f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/core/super-converter/SuperConverter.js
Outdated
Show resolved
Hide resolved
- Simplified telemetry logging in the Editor class by removing unnecessary comments and enhancing debug output for document information. - Removed redundant isNewFile tracking in SuperDoc, allowing automatic handling based on context.
- Introduced default community license key in the Editor class for telemetry initialization. - Updated `initTelemetry` function to use the default license key when none is provided. - Added tests to verify behavior with default and custom license keys. - Improved documentation for the community license key usage.
caio-pizzol
reviewed
Feb 4, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
nice work! just a few comments
packages/super-editor/src/core/super-converter/SuperConverter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/SuperConverter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/SuperConverter.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@caio-pizzol forgot to mention. I intentionally left console logs and livetest url here for easy testing. Once code reviewed - I'll remove that of course |
- Introduced a guard flag to prevent double-tracking of document opens in the Editor class. - Updated document identifier generation to be asynchronous, ensuring metadata is available before tracking. - Enhanced SuperConverter to manage document timestamps and unique identifiers more effectively. - Added new utility methods for generating Word-compatible timestamps and content hashes. - Improved test coverage for document identifier resolution and timestamp handling in various scenarios.
caio-pizzol
reviewed
Feb 5, 2026
caio-pizzol
reviewed
Feb 5, 2026
caio-pizzol
approved these changes
Feb 5, 2026
- Renamed `isNewFile` to `isBlankDoc` in SuperConverter for clarity regarding document creation context. - Updated related comments and documentation to reflect the new naming and functionality. - Enhanced test cases to align with the refactored telemetry and document handling logic.
andrii-harbour
force-pushed
the
andrii/sd-1638-telemetry-create-telemetry-set-up-in-superdoc-core-lib
branch
from
05fae90 to
43e0d97
Compare
- Ensured document metadata is generated regardless of telemetry settings
harbournick
requested changes
Feb 5, 2026
Collaborator
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
Just the null licenseKey/default stuff otherwise looks good!
- Simplified license key management in telemetry initialization. - Updated tests to reflect changes in license key usage and ensure correct behavior. - Introduced COMMUNITY_LICENSE_KEY constant for consistent license key usage across modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initTelemetrymethod in the Editor class to initialize telemetry based on configuration.